fix(US): Set US Modality Pixel Spacing to 1:1 for Rendering #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedghi
reviewed
Oct 20, 2025
|
|
||
| const pixelArray = image.voxelManager.getScalarData(); | ||
|
|
||
| if (this.modality === 'US') { |
Collaborator
Author
There was a problem hiding this comment.
why it passed CI
Collaborator
There was a problem hiding this comment.
This is going to cause measurement failures. The right way to do it is to add aspect ratio information and incorporate that into the transform for canvas to world coordinates and vice-versa. The aspect ratio should be a camera property set by the vtk data. Probably having both a base aspect ratio and a displayed aspect ratio relative to the base ratio would be best.
Member
There was a problem hiding this comment.
@IbrahimCSAE can you confirm this example works in the other PR Bill has for calibration and US fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes ultrasound (US) image rendering by enforcing a pixel spacing of 1.0 x 1.0, independent of any region-based calibration metadata (e.g., Physical Delta X/Y from the Ultrasound Region Calibration Module).
DICOM-compliant ultrasound images typically do not define global Pixel Spacing. Instead, calibration is region-specific and intended for quantitative measurements, not geometric rescaling. Applying PhysicalDeltaX/Y to image rendering leads to incorrect aspect ratios, as spacing often varies per region and may encode non-spatial units (e.g., time, velocity).
The recommended practice is to use ultrasound pixel spacing (Physical Delta X/Y from the calibration data) only for measurement calibration, and not for altering the fundamental display of the image
Fixes:
Measurement tools can still consume the region calibration for accurate physical units without affecting the visual presentation.