Skip to content

fix(US): Set US Modality Pixel Spacing to 1:1 for Rendering #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(US): Set US Modality Pixel Spacing to 1:1 for Rendering #2410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/RenderingEngine/StackViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2452,6 +2452,12 @@ class StackViewport extends Viewport {
// or the size has changed), create a new one

const pixelArray = image.voxelManager.getScalarData();

if (this.modality === 'US') {
Copy link
Member

@sedghi sedghi Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely formatting is wrong

Copy link
Collaborator Author

@IbrahimCSAE IbrahimCSAE Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it passed CI

Copy link
Collaborator

@wayfarer3130 wayfarer3130 Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to cause measurement failures. The right way to do it is to add aspect ratio information and incorporate that into the transform for canvas to world coordinates and vice-versa. The aspect ratio should be a camera property set by the vtk data. Probably having both a base aspect ratio and a displayed aspect ratio relative to the base ratio would be best.

Copy link
Member

@sedghi sedghi Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IbrahimCSAE can you confirm this example works in the other PR Bill has for calibration and US fixes

spacing[1] = 1
spacing[0] = 1
}

this._createVTKImageData({
origin,
direction,
Expand Down
Loading