Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions podman/domain/networks_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ def create(self, name: str, **kwargs) -> Network:
check_duplicate (bool): Ignored, always False.
dns_enabled (bool): DNSEnabled is whether name resolution is active for container on
this Network. Only supported with the bridge driver.
network_dns_servers (list[str]): List of custom DNS server for podman's DNS resolver
at network level, all the containers attached to this network will
consider resolvers configured at network level.
driver (str): Which network driver to use when creating network.
enable_ipv6 (bool): Enable IPv6 on the network.
ingress (bool): Ignored, always False.
Expand All @@ -57,6 +60,7 @@ def create(self, name: str, **kwargs) -> Network:
"name": name,
"driver": kwargs.get("driver"),
"dns_enabled": kwargs.get("dns_enabled"),
"network_dns_servers": kwargs.get("network_dns_servers"),
"subnets": kwargs.get("subnets"),
"ipv6_enabled": kwargs.get("enable_ipv6"),
"internal": kwargs.get("internal"),
Expand Down
25 changes: 25 additions & 0 deletions podman/tests/unit/test_networksmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,31 @@ def test_create_defaults(self, mock):
{"name": "podman"},
)

@requests_mock.Mocker()
def test_create_network_dns_servers(self, mock):
adapter = mock.post(tests.LIBPOD_URL + "/networks/create", json=FIRST_NETWORK_LIBPOD)

network = self.client.networks.create("podman", network_dns_servers=["192.0.2.1"])
self.assertIsInstance(network, Network)

self.assertEqual(adapter.call_count, 1)
self.assertDictEqual(
adapter.last_request.json(),
{"name": "podman", "network_dns_servers": ["192.0.2.1"]},
)

network = self.client.networks.create(
"podman", network_dns_servers=["192.0.2.1", "192.0.2.2"]
)

self.assertIsInstance(network, Network)

self.assertEqual(adapter.call_count, 2)
self.assertDictEqual(
adapter.last_request.json(),
{"name": "podman", "network_dns_servers": ["192.0.2.1", "192.0.2.2"]},
)

@requests_mock.Mocker()
def test_prune_libpod(self, mock):
mock.post(
Expand Down