add network_dns_servers as supported parameter to network.create#630
Merged
inknos merged 1 commit intocontainers:mainfrom Mar 6, 2026
Merged
Conversation
mutax
force-pushed
the
add_network_dns_servers_support
branch
from
61c89f1 to
d7cbfaf
Compare
Honny1
requested changes
Feb 24, 2026
Member
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
Can you please add tests for this?
mutax
force-pushed
the
add_network_dns_servers_support
branch
from
d7cbfaf to
a3adcf8
Compare
Contributor
Author
|
@Honny1 I am not sure if just testing the case with setting two entries would be enough, but only testing a one-element list didn't seem sufficient to me. Is that what you had in mind? |
mutax
force-pushed
the
add_network_dns_servers_support
branch
from
a3adcf8 to
9e1a5c6
Compare
The API endpoint supports setting a list of custom DNS servers when creating a network, but the argument was not passed along. This adds the argument network_dns_servers to the API call and implements a unit test for setting one or multiple DNS servers. See https://docs.podman.io/en/latest/_static/api.html?version=latest#tag/networks/operation/NetworkCreateLibpod Signed-off-by: Florian Streibelt <mail+github@yakshaving.de>
mutax
force-pushed
the
add_network_dns_servers_support
branch
from
9e1a5c6 to
d1e0ccc
Compare
Member
|
PTAL @inknos |
Contributor
|
I think tests are fine. Thanks for the contribution @mutax . LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API endpoint supports setting a list of custom DNS servers when creating a network but the argument was not passed along.
This adds the argument
network_dns_serversto the API call.See https://docs.podman.io/en/latest/_static/api.html?version=latest#tag/networks/operation/NetworkCreateLibpod