Conversation
folex
reviewed
May 9, 2024
folex
reviewed
May 9, 2024
folex
reviewed
May 9, 2024
folex
reviewed
May 9, 2024
|
|
||
| Your actor has now been deployed and we should be able to send it messages! | ||
|
|
||
| # Genesis Parameters |
There was a problem hiding this comment.
Should this maybe be a separate spec doc?
Contributor
There was a problem hiding this comment.
Yeah, definitely belongs in a separate doc.
folex
reviewed
May 9, 2024
folex
reviewed
May 9, 2024
| - `timestamp` is the number of seconds since UNIX epoch | ||
| - `network_version` is used by the FVM to select gas pricing policy | ||
| - `base_fee` is measured in *atto* and represents the base price for gas | ||
| - `power_scale` is the number of decimals to take into account from the FIL token collateral balance when converting it into voting power expressed as `u64`, which is what CometBFT expects. For example if the scale is 0 then every 1 FIL gives 1 voting power, if it’s 3 then every 0.001 FIL does, and if it’s -1 then every 10 FIL. The power is rounded upwards, so that we don’t end up with 0 power, which would be rejected by CometBFT; for example if the scale is 1, then both 1.1 FIL and 1.9 FIL give 2 power. |
There was a problem hiding this comment.
maybe mention that it only works for the Collateral (ie PoS) mode?
Contributor
There was a problem hiding this comment.
So... as we've noted recently, this applies in Federated mode too.
folex
reviewed
May 9, 2024
|
|
||
| # Gas policy | ||
|
|
||
| The gas price in the FVM is by default [determined](https://github.com/filecoin-project/ref-fvm/blob/c39d880d086aa2e771c7190163436e02715d80f3/fvm/src/machine/mod.rs#L156) by the network version when the `NetworkConfig` is created, but could further be customised by assigning to the `price_list` field. Should Fendermint have to do that, it would be in the [constructor](https://github.com/consensus-shipyard/ipc/blob/7af25c4c860f5ab828e8177927a0f8b6b7a7cc74/fendermint/vm/interpreter/src/fvm/state/exec.rs#L132) of the `FvmExecState`. |
There was a problem hiding this comment.
assigning to the
price_listfield
price_list is hypothetical here or where does it come from?
Contributor
There was a problem hiding this comment.
The FVM will return a price_list for the specified Filecoin network version, but the user can customize it before creating an FVM Machine.
folex
reviewed
May 9, 2024
raulk
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation for IPC Customazbility