Skip to content

docs: move docs into monorepo#1014

Merged
raulk merged 107 commits intomainfrom
maciej/docs
Aug 26, 2024
Merged

docs: move docs into monorepo#1014
raulk merged 107 commits intomainfrom
maciej/docs

Conversation

@maciejwitowski
Copy link
Copy Markdown
Contributor

@maciejwitowski maciejwitowski commented May 28, 2024

At the moment, IPC docs are in the separate repo https://github.com/consensus-shipyard/docs
We want to simplify them by adding to this repo. Since in this repo docs folder already exists, they were put in docs-gitbook. The structure and naming of docs can be easily updated later.

Next, the migrated docs are used to render the gitbook page. I created this separate gitbook space for the purpose of checking. It will replace the main one once this PR is merged.

gitbook-bot and others added 30 commits October 23, 2023 15:15
jsoares and others added 6 commits April 19, 2024 15:48
Remove --public-key from quickstart
Callout that automatic restarts should be disabled when reaching halting height
…b2e3'

git-subtree-dir: docs-gitbook
git-subtree-mainline: b6d472d
git-subtree-split: a5d33a6
Copy link
Copy Markdown
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the images out of this repo to avoid bloating git clones. If they were light design/architecture diagrams, I wouldn't mind hosting them here. But not worth it for unoptimized tutorial screenshots.

I'd suggest the following:

  1. Keep media assets in the original docs repo, and embed them in the Markdowns using a GitHub URL.
  2. Rename the images to self-descriptive names. Right now we have series of metamask (1).png, metamask (2).png... files.

@maciejwitowski
Copy link
Copy Markdown
Contributor Author

@raulk Not bloating the repo makes sense.
IIUC git clone will still be bloated if I just add a commit which removes assets folder from this repo and changes the links, correct? Does it mean I should copy folders/files without migrating the whole history?

@raulk
Copy link
Copy Markdown
Contributor

raulk commented May 29, 2024

@maciejwitowski it won't because we'll be squashing this PR in. You can migrate the assets by adding a commit to this PR.

@maciejwitowski
Copy link
Copy Markdown
Contributor Author

@raulk Please check again. The docs website is already running from this branch https://docs.ipc.space/
Had to clean all these files in the docs repo, since they were added by gitbook via drag & drop and most of them were not referenced anywhere.

@maciejwitowski
Copy link
Copy Markdown
Contributor Author

After this branch is merged I'm gonna switch docs website to use main.

Copy link
Copy Markdown
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as a starting point, even though the content needs significant revision.

Just one question before I merge this: how does editing via the GitBook web interface work in this case?

We absolutely don't want (a) the GitBook bot committing directly to this repo, or (b) the GitBook bot to appear as a Git author anywhere.

karlem added 4 commits June 27, 2024 12:38
…rent docs (#1040)

This pull request aims to enhance the existing documentation by
introducing a new section on how it works and updating the benefits
overview to provide clearer and more comprehensive information to the
users. The changes include:

Addition of a new section covering how IPC works, detailing its purpose
and usage.
Updates to the benefits overview, highlighting the key advantages and
improvements of the current system.
These improvements are intended to make the documentation more
user-friendly and informative, aiding users in better understanding and
utilizing the features of our product.
@raulk raulk changed the title Moving docs into monorepo docs: move docs into monorepoamannn/action-semantic-pull-request Aug 26, 2024
@raulk raulk changed the title docs: move docs into monorepoamannn/action-semantic-pull-request docs: move docs into monorepo Aug 26, 2024
@raulk raulk requested a review from a team as a code owner August 26, 2024 15:57
@raulk raulk enabled auto-merge (squash) August 26, 2024 16:00
@raulk raulk disabled auto-merge August 26, 2024 16:00
@raulk raulk merged commit c3b33ee into main Aug 26, 2024
@raulk raulk deleted the maciej/docs branch August 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

10 participants