Conversation
raulk
approved these changes
Dec 10, 2024
Comment on lines
+78
to
+80
| require(saDiamond.getter().genesisValidators().length == 0, "unexpected genesis validators"); | ||
| require(saDiamond.getter().getActiveValidators().length == 0, "unexpected active validators"); | ||
| require(saDiamond.getter().getWaitingValidators().length == 0, "unexpected waiting validators"); |
Contributor
There was a problem hiding this comment.
Good work strengthening the assertions here with the new accessors!
| #[derive(Debug, Args)] | ||
| #[command( | ||
| name = "list validators", | ||
| about = "List the info of all the validators in the subnet" |
Contributor
There was a problem hiding this comment.
Suggested change
| about = "List the info of all the validators in the subnet" | |
| about = "List the info of all the validators in the subnet, as viewed by the parent" |
Contributor
There was a problem hiding this comment.
Important to note this, since one would default to thinking that we're querying the subnet itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1095