Rebuild for python 3.13 by regro-cf-autotick-bot · Pull Request #249 · conda-forge/conda-feedstock

regro-cf-autotick-bot · 2024-12-20T16:04:42Z

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12434062644 - please use this URL for debugging.}

Fixes #246

…onda-forge-pinning 2024.12.20.14.58.42

conda-forge-admin · 2024-12-20T16:06:18Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

wshanks · 2024-12-31T22:54:56Z

I am trying to understand the problem here. It seems like the build tries to install conda into the Python 3.13 environment for the 3.13 builds but that fails because the 3.13 build of conda doesn't exist yet? Somehow this is not an issue for 3.13 builds of things other than conda though....

…thon313-0-1_h8f2626

jakirkham · 2025-02-04T01:57:51Z

@conda-forge-admin , please re-render

conda-forge-admin · 2025-02-04T01:59:51Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13126756975. Examine the logs at this URL for more detail.}

jakirkham · 2025-02-04T02:01:05Z

@conda-forge-admin , please re-render

conda-forge-admin · 2025-02-04T02:03:33Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13126795959. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-04T02:49:19Z

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13127489722. Examine the logs at this URL for more detail.}

* Provide a default value for `python` * Convert values to `int` * Ensure the final result is a `list`

conda-forge-admin · 2025-02-04T03:30:33Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Besides this is equivalent to `win`, which can already be used.

This doesn't change. Inlining it gives us one less thing to think about.

To push out Python 3.13, temporarily disable conda-build's tests. A simple re-render will add them back. After Python 3.13 packages are available, the tests should pass again.

jakirkham

As noted in issue ( #246 ), there is a cycle as conda-libmamba-solver requires conda, which in turn requires conda-libmamba-solver. It sounds like we don't want to break the cycle either

Tried a few ways to bypass the cycle here, it looks like the best approach is just to pass --no-tests to disable the test phase entirely

Have done this below and commented on where. All of these are in CI files that will be overwritten when conda-smithy re-renders

This should help us get Conda packages out for Python 3.13. We can re-enable tests with a re-render after

jakirkham · 2025-02-04T04:01:25Z

+# Temporary hack to skip testing and push out Python 3.13.
+# Re-rendering after will revert this.
+EXTRA_CB_OPTIONS="${EXTRA_CB_OPTIONS:-} --no-test"


This temporarily disables the package test phase on Linux

jakirkham · 2025-02-04T04:01:37Z

+# Temporary hack to skip testing and push out Python 3.13.
+# Re-rendering after will revert this.
+EXTRA_CB_OPTIONS="${EXTRA_CB_OPTIONS:-} --no-test"


This temporarily disables the package test phase on macOS

jakirkham · 2025-02-04T04:01:55Z

+:: Temporary hack to skip testing and push out Python 3.13.
+:: Re-rendering after will revert this.
+set "EXTRA_CB_OPTIONS=%EXTRA_CB_OPTIONS% --no-test"


This temporarily disables the package test phase on Windows

jakirkham · 2025-02-04T04:02:49Z

+  patches:
+    # Backport https://github.com/conda/conda/pull/14117 for changes in the
+    # Python 3.13+ logging module internals
+    - patches/0001-GH-14117-logging-lock-internal-changes-py313.patch


Have merged in Bradley's PR ( #258 ), which the patch from upstream PR ( conda/conda#14117 )

conda/conda#14584 may be a better patch to pull in as it was merged.

Thanks Jonathan! 🙏

Glad to see your fix landed 🙂

Yeah we can update the patch. Would you like to send a PR to update it?

beckermr · 2025-02-04T04:50:52Z

ok LGTM!

regro-cf-autotick-bot added 2 commits December 20, 2024 16:03

Rebuild for python 3.13

9b48aa3

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.1, and c…

f5df22a

…onda-forge-pinning 2024.12.20.14.58.42

regro-cf-autotick-bot requested review from beeankha, dbast, isuruf, jakirkham, jezdez, kenodegard, mbargull and ocefpaf as code owners December 20, 2024 16:04

jan-janssen mentioned this pull request Jan 8, 2025

Test with Python 3.13 pyiron/conda_subprocess#61

Closed

Add patch from upstream PR for Python 3.13 compatibility.

06bb4fc

bdice mentioned this pull request Feb 2, 2025

Add patch from upstream PR for Python 3.13 compatibility. #258

Merged

5 tasks

Bump build number.

d5b5ee0

beckermr reviewed Feb 3, 2025

View reviewed changes

Comment thread recipe/meta.yaml

beckermr added 2 commits February 2, 2025 19:12

Update meta.yaml

8888ef3

Update meta.yaml

a8da6a7

beckermr reviewed Feb 3, 2025

View reviewed changes

Comment thread recipe/meta.yaml Outdated

beckermr and others added 3 commits February 2, 2025 19:58

Update meta.yaml

83db4d6

Skip conda-smithy downstream test on Python 3.13

815bcd4

Merge bdice/patch-for-python313 into regro-cf-autotick-bot/rebuild-py…

8561f3e

…thon313-0-1_h8f2626

Tweak Python 3.13 selector syntax

71ec9e0

jakirkham added 2 commits February 3, 2025 18:37

Try commenting tests to get Python 3.13 out

8f3db5e

Guard test section from newer Pythons

f3fc888

jakirkham added 2 commits February 3, 2025 19:03

Use list for Python version comparison

dd31f88

More Jinja fixes

d05329a

* Provide a default value for `python` * Convert values to `int` * Ensure the final result is a `list`

jakirkham added 4 commits February 3, 2025 19:34

Revert Jinja approach to skipping tests

6e05efb

Drop unused on_win variable

1e72c07

Besides this is equivalent to `win`, which can already be used.

Inline name variable

7f2dbb5

This doesn't change. Inlining it gives us one less thing to think about.

Temporarily disable running conda-build's tests

6bda721

To push out Python 3.13, temporarily disable conda-build's tests. A simple re-render will add them back. After Python 3.13 packages are available, the tests should pass again.

jakirkham reviewed Feb 4, 2025

View reviewed changes

jakirkham mentioned this pull request Feb 4, 2025

Python 3.13 migrator failing #246

Closed

1 task

beckermr reviewed Feb 4, 2025

View reviewed changes

Comment thread recipe/meta.yaml Outdated

Update recipe/meta.yaml

8cdbdad

larsoner mentioned this pull request Feb 11, 2025

ENH: Use Python 3.13 mne-tools/mne-installers#332

Merged

isuruf merged commit b4366b5 into conda-forge:main Feb 18, 2025

regro-cf-autotick-bot deleted the rebuild-python313-0-1_h8f2626 branch February 18, 2025 22:15

This was referenced Feb 18, 2025

Revert --no-test workaround #260

Open

Rebuild for python 3.13 conda-forge/conda-build-feedstock#246

Closed

This was referenced Oct 8, 2025

Rebuild for python 3.14 #274

Merged

Rebuild Python314 with a fix for circular dependency #277

Closed

Uh oh!

Conversation

regro-cf-autotick-bot commented Dec 20, 2024 • edited by jakirkham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Dec 20, 2024

Uh oh!

wshanks commented Dec 31, 2024

Uh oh!

Uh oh!

Uh oh!

jakirkham commented Feb 4, 2025

Uh oh!

conda-forge-admin commented Feb 4, 2025

Uh oh!

jakirkham commented Feb 4, 2025

Uh oh!

conda-forge-admin commented Feb 4, 2025

Uh oh!

conda-forge-admin commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Feb 4, 2025

Uh oh!

jakirkham left a comment

Choose a reason for hiding this comment

Uh oh!

jakirkham Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jakirkham Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jakirkham Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jakirkham Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jjhelmus Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

jakirkham Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

beckermr commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

regro-cf-autotick-bot commented Dec 20, 2024 •

edited by jakirkham

Loading

conda-forge-admin commented Feb 4, 2025 •

edited

Loading