add block/transaction impl #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1166
💛 - Coveralls |
shrimalmadhur
force-pushed
the
madhur/block-tx-impl
branch
from
c1b2e1b to
e90b708
Compare
shrimalmadhur
force-pushed
the
madhur/block-tx-impl
branch
from
e90b708 to
a507b6c
Compare
ethereum/testdata/block_0xc10a51a3898a85c7165a9d883acc9a68f139934d0cb91dfad4c7d3a7c1a1960d.json
Show resolved
Hide resolved
xiaying-peng
requested changes
Jan 28, 2022
Contributor
xiaying-peng
left a comment
xiaying-peng
left a comment
There was a problem hiding this comment.
Great changes, left some comments for cleanup.
|
Review Error for xiaying-peng @ 2022-01-28 07:41:22 UTC |
xiaying-peng
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85 .
Motivation
We don't have
/block/transactionendpoint implementedSolution
Implement the endpoint for querying transaction by transaction hash
Open questions