json response

Author: shrimalmadhur

ethereum/client.go

@@ -207,7 +207,7 @@ func toBlockNumArg(number *big.Int) string {
 }
 
 // Transaction returns the transaction response of the Transaction identified
-// by *RosettaTypes.TransactionIdentifier hash or index
+// by *RosettaTypes.TransactionIdentifier hash
 func (ec *Client) Transaction(
 	ctx context.Context,
 	blockIdentifier *RosettaTypes.BlockIdentifier,
@@ -284,7 +284,7 @@ func (ec *Client) Transaction(
 		}
 		return tx, nil
 	}
-	return nil, errors.New("unimplemented")
+	return nil, errors.New("transaction hash is required")
 }
 
 // Block returns a populated block at the *RosettaTypes.PartialBlockIdentifier.

ethereum/client_test.go

@@ -1392,6 +1392,20 @@ func TestBlock_Index(t *testing.T) {
 	mockGraphQL.AssertExpectations(t)
 }
 
+func jsonifyTransaction(b *RosettaTypes.Transaction) (*RosettaTypes.Transaction, error) {
+	bytes, err := json.Marshal(b)
+	if err != nil {
+		return nil, err
+	}
+
+	var tx RosettaTypes.Transaction
+	if err := json.Unmarshal(bytes, &tx); err != nil {
+		return nil, err
+	}
+
+	return &tx, nil
+}
+
 func jsonifyBlock(b *RosettaTypes.Block) (*RosettaTypes.Block, error) {
 	bytes, err := json.Marshal(b)
 	if err != nil {
@@ -1529,9 +1543,12 @@ func TestTransaction_Hash(t *testing.T) {
 			Hash: "0x9cc8e6a09ae9cbdb7da77515110a8e343a945df4269c53842dd26969d32c6cc4",
 		},
 	)
-	assert.Equal(t, correct.Transaction, resp)
 	assert.NoError(t, err)
 
+	jsonResp, err := jsonifyTransaction(resp)
+	assert.NoError(t, err)
+	assert.Equal(t, correct.Transaction, jsonResp)
+
 	mockJSONRPC.AssertExpectations(t)
 	mockGraphQL.AssertExpectations(t)
 }