Skip to content

fix VP8X feature flags byte offset#2199

Merged
colinrtwhite merged 1 commit into
coil-kt:mainfrom
UdaraWanasinghe:coil3-gif-fix
Apr 12, 2024
Merged

fix VP8X feature flags byte offset#2199
colinrtwhite merged 1 commit into
coil-kt:mainfrom
UdaraWanasinghe:coil3-gif-fix

Conversation

@UdaraWanasinghe
Copy link
Copy Markdown
Contributor

VP8X chunk byte format
12..15    "VP8X": 4-bytes tags, describing the extended-VP8 chunk
16..19    Size of the VP8X chunk starting at offset 20
20....      VP8X bytes

References:
https://developers.google.com/speed/webp/docs/riff_container#extended_file_format

12..15    "VP8X": 4-bytes tags, describing the extended-VP8 chunk
16..19    Size of the VP8X chunk starting at offset 20
20....      VP8X bytes

References:
https://developers.google.com/speed/webp/docs/riff_container#extended_file_format
@colinrtwhite
Copy link
Copy Markdown
Member

Great catch, thanks! For some reason I thought ChunkHeader('VP8X') was only 4 bytes, but it mentions it's 8 in the spec.

@colinrtwhite colinrtwhite merged commit 70c768e into coil-kt:main Apr 12, 2024
colinrtwhite added a commit that referenced this pull request Apr 30, 2024
* main:
  Fix deploy docs timeout.
  Fix disabling polyfills for samples.
  Update dependency org.jetbrains.compose.compiler:compiler to v1.5.10.2 (#2216)
  Publish the sample wasmJs app automatically when deploying the docs. (#2213)
  Update androidx.activity to v1.9.0 (#2209)
  Update androidx.benchmark to v1.2.4 (#2208)
  Update dependency org.jetbrains.kotlinx:atomicfu-gradle-plugin to v0.24.0 (#2206)
  Update dependency org.jetbrains.skiko:skiko to v0.8.1 (#2207)
  Update dependency androidx.core:core-ktx to v1.13.0 (#2210)
  Update roborazzi to v1.13.0 (#2212)
  Upgrade to gradle/actions/wrapper-validation@v3. (#2203)
  Update gradle/wrapper-validation-action action to v3 (#2202)
  fix VP8X feature flags byte offset (#2199)
  Update roborazzi to v1.12.0 (#2201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants