Skip to content

Commit f2633c2

Browse files
committed
Merge branch 'main' into colin/kotlin_2
* main: Fix deploy docs timeout. Fix disabling polyfills for samples. Update dependency org.jetbrains.compose.compiler:compiler to v1.5.10.2 (#2216) Publish the sample wasmJs app automatically when deploying the docs. (#2213) Update androidx.activity to v1.9.0 (#2209) Update androidx.benchmark to v1.2.4 (#2208) Update dependency org.jetbrains.kotlinx:atomicfu-gradle-plugin to v0.24.0 (#2206) Update dependency org.jetbrains.skiko:skiko to v0.8.1 (#2207) Update dependency androidx.core:core-ktx to v1.13.0 (#2210) Update roborazzi to v1.13.0 (#2212) Upgrade to gradle/actions/wrapper-validation@v3. (#2203) Update gradle/wrapper-validation-action action to v3 (#2202) fix VP8X feature flags byte offset (#2199) Update roborazzi to v1.12.0 (#2201)
2 parents 75a9c29 + 92ba8b2 commit f2633c2

10 files changed

Lines changed: 186 additions & 78 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
java-version: ${{ env.JAVA_VERSION }}
2525

2626
- name: Check Gradle wrapper
27-
uses: gradle/wrapper-validation-action@v2
27+
uses: gradle/actions/wrapper-validation@v3
2828

2929
- name: Check style
3030
run: ./gradlew spotlessCheck
@@ -142,7 +142,7 @@ jobs:
142142
deploy-docs:
143143
name: Deploy docs
144144
runs-on: ubuntu-latest
145-
timeout-minutes: 20
145+
timeout-minutes: 40
146146
if: github.repository == 'coil-kt/coil' && github.ref == 'refs/heads/main'
147147
needs: [checks, unit-tests, instrumentation-tests, build-samples]
148148
steps:

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ build
1818

1919
# Docs
2020
docs/api
21+
docs/sample
2122
site
2223

2324
# Xcode

build.gradle.kts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,11 @@ allprojects {
177177

178178
// https://github.com/square/okio/issues/1163
179179
fun Project.applyOkioJsTestWorkaround() {
180+
if (":samples" in displayName) {
181+
// The polyfills cause issues with the samples.
182+
return
183+
}
184+
180185
plugins.withId("org.jetbrains.kotlin.multiplatform") {
181186
val applyNodePolyfillPlugin by lazy {
182187
tasks.register("applyNodePolyfillPlugin") {

coil-gif/src/main/java/coil3/gif/decodeUtils.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ fun DecodeUtils.isWebP(source: BufferedSource): Boolean {
4242
fun DecodeUtils.isAnimatedWebP(source: BufferedSource): Boolean {
4343
return isWebP(source) &&
4444
source.rangeEquals(12, WEBP_HEADER_VPX8) &&
45-
source.request(17) &&
46-
(source.buffer[16] and 0b00000010) > 0
45+
source.request(21) &&
46+
(source.buffer[20] and 0b00000010) > 0
4747
}
4848

4949
/**

deploy_docs.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
#!/bin/bash
22
set -e
33

4+
# Build the Compose WASM sample.
5+
./gradlew samples:compose:wasmJsBrowserDistribution
6+
7+
# Copy outside files into the docs folder.
8+
cp -R samples/compose/build/dist/wasmJs/productionExecutable docs/sample
9+
410
# Build the Dokka docs.
511
./assemble_docs.sh
612

@@ -40,5 +46,6 @@ rm docs/index.md \
4046
docs/README-sv.md \
4147
docs/README-tr.md \
4248
docs/README-zh.md
43-
rm -r docs/api
44-
rm -r site
49+
rm -r docs/api \
50+
docs/sample \
51+
site

gradle/libs.versions.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[versions]
2-
androidx-activity = "1.8.2"
3-
androidx-benchmark = "1.2.3"
2+
androidx-activity = "1.9.0"
3+
androidx-benchmark = "1.2.4"
44
androidx-lifecycle = "2.7.0"
55
coroutines = "1.8.0"
66
jetbrains-compose = "1.6.2"
@@ -12,7 +12,7 @@ ktor-wasm = "3.0.0-wasm2"
1212
okhttp = "4.12.0"
1313
okio = "3.9.0"
1414
paparazzi = "1.3.3"
15-
roborazzi = "1.11.0"
15+
roborazzi = "1.13.0"
1616
skiko = "0.7.97"
1717

1818
[plugins]
@@ -24,7 +24,7 @@ spotless = "com.diffplug.spotless:6.25.0"
2424

2525
[libraries]
2626
gradlePlugin-android = "com.android.tools.build:gradle:8.3.2"
27-
gradlePlugin-atomicFu = "org.jetbrains.kotlinx:atomicfu-gradle-plugin:0.23.2"
27+
gradlePlugin-atomicFu = "org.jetbrains.kotlinx:atomicfu-gradle-plugin:0.24.0"
2828
gradlePlugin-jetbrainsCompose = { module = "org.jetbrains.compose:compose-gradle-plugin", version.ref = "jetbrains-compose" }
2929
gradlePlugin-kotlin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
3030
gradlePlugin-mavenPublish = "com.vanniktech:gradle-maven-publish-plugin:0.28.0"
@@ -37,7 +37,7 @@ androidx-appcompat-resources = "androidx.appcompat:appcompat-resources:1.6.1"
3737
androidx-annotation = "androidx.annotation:annotation:1.7.1"
3838
androidx-benchmark-macro = { module = "androidx.benchmark:benchmark-macro-junit4", version.ref = "androidx-benchmark" }
3939
androidx-constraintlayout = "androidx.constraintlayout:constraintlayout:2.1.4"
40-
androidx-core = "androidx.core:core-ktx:1.12.0"
40+
androidx-core = "androidx.core:core-ktx:1.13.0"
4141
androidx-exifinterface = "androidx.exifinterface:exifinterface:1.3.7"
4242
androidx-lifecycle-runtime = { module = "androidx.lifecycle:lifecycle-runtime", version.ref = "androidx-lifecycle" }
4343
androidx-lifecycle-viewmodel = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "androidx-lifecycle" }

0 commit comments

Comments
 (0)