tracing: misc cleanups #72727
Merged
tracing: misc cleanups #72727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
andreimatei
force-pushed
the
tracing.fix-comment
branch
from
e526f69 to
9c29908
Compare
andreimatei
force-pushed
the
tracing.fix-comment
branch
from
9c29908 to
9784d5e
Compare
abarganier
approved these changes
Nov 16, 2021
Contributor
abarganier
left a comment
abarganier
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
The span.ResetRecording() method was fairly unused. It's also in my way because it clears the children of a span without properly making them part of the active spans registry (like for example parent.Finish() would do). This patch gets rid of it. Release note: None
This TODO implied that orphaned spans (spans whose parent is Finish()ing) are not made part of the active spans registry. But they are, just above the TODO. Release note: None
andreimatei
force-pushed
the
tracing.fix-comment
branch
from
9784d5e to
d60e17a
Compare
andreimatei
commented
Nov 18, 2021
Contributor
Author
andreimatei
left a comment
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.