Skip to content

Commit 9784d5e

Browse files
committed
tracing: remove stale TODO
This TODO implied that orphaned spans (spans whose parent is Finish()ing) are not made part of the active spans registry. But they are, just above the TODO. Release note: None
1 parent f24d684 commit 9784d5e

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

pkg/util/tracing/crdbspan.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,16 +183,13 @@ func (s *crdbSpan) finish() bool {
183183
parent.childFinished(s)
184184
}
185185

186+
// Deal with the orphaned children - make them roots.
186187
for _, c := range children {
187188
c.parentFinished()
188189
}
189-
190190
// Atomically replace s in the registry with all of its still-open children.
191191
s.tracer.activeSpansRegistry.swap(s.spanID, children)
192192

193-
// TODO(andrei): All the children that are still open are getting orphaned by
194-
// the finishing of this parent. We should make them all root spans and
195-
// register them with the active spans registry.
196193
return true
197194
}
198195

0 commit comments

Comments
 (0)