Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Oct 30, 2024

Backport 1/1 commits from #133245 on behalf of @mgartner.

/cc @cockroachdb/release


Fixes #133015

Release note: None


Release justification: Low-risk bug fix.

@blathers-crl blathers-crl bot requested a review from a team as a code owner October 30, 2024 17:27
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-133245 branch from 1baf743 to cdd6d1d Compare October 30, 2024 17:27
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team October 30, 2024 17:27
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 30, 2024
@blathers-crl blathers-crl bot requested a review from DrewKimball October 30, 2024 17:27
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 30, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 30, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested a review from a team October 31, 2024 13:28
Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rytaft)

@DrewKimball DrewKimball merged commit 92cf079 into release-24.3 Oct 31, 2024
20 of 21 checks passed
@DrewKimball DrewKimball deleted the blathers/backport-release-24.3-133245 branch October 31, 2024 17:52
@crl-codesys-jira crl-codesys-jira added the T-sql-queries SQL Queries Team label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants