sql/tests: TestRandomSyntaxFunctions failed [makeslice: len out of range]

[cockroach-teamcity]

sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.2 @ 77237763413fff744e598f85a8b554ac3de66c38:

Random syntax error:

    rsg_test.go:962: Crash detected: server panic: pq: internal error: runtime error: makeslice: len out of range

Query:

        SELECT crdb_internal.decode_external_plan_gist('Aifvzn5p':::STRING) ;

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-43410

[spilchen]

This doesn't seem like a recent regression. I was able to see the exact failure when run on a 23.1 instance:

roachprod@localhost:26257/defaultdb> select version();
                                       version
--------------------------------------------------------------------------------------
  CockroachDB CCL v23.1.0 (x86_64-pc-linux-gnu, built 2023/05/15 15:23:23, go1.19.4)
(1 row)

Time: 1ms total (execution 0ms / network 0ms)

roachprod@localhost:26257/defaultdb> SELECT crdb_internal.decode_external_plan_gist('Aifvzn5p':::STRING) ;
ERROR: internal error: runtime error: makeslice: len out of range
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/util/errorutil/catch.go:29: ShouldCatch()
github.com/cockroachdb/cockroach/pkg/sql/opt/exec/explain/plan_gist_factory.go:169: func1()
GOROOT/src/runtime/panic.go:884: gopanic()
GOROOT/src/runtime/slice.go:29: panicmakeslicelen()
GOROOT/src/runtime/slice.go:98: makeslice()
github.com/cockroachdb/cockroach/pkg/sql/opt/exec/explain/plan_gist_factory.go:344: decodeResultColumns()
github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/exec/explain/plan_gist_factory.og.go:1350: decodeOperatorBody()
github.com/cockroachdb/cockroach/pkg/sql/opt/exec/explain/plan_gist_factory.go:240: decodeOp()
github.com/cockroachdb/cockroach/pkg/sql/opt/exec/explain/plan_gist_factory.go:213: DecodePlanGistToPlan()
github.com/cockroachdb/cockroach/pkg/sql/opt/exec/explain/plan_gist_factory.go:181: DecodePlanGistToRows()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:716: DecodeGist()
github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/generator_builtins.go:628: Start()

[spilchen]

Moving to SQL queries team. It looks like this has existed since at least 23.1