-
Notifications
You must be signed in to change notification settings - Fork 368
Update KServe logos #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KServe logos #603
Conversation
Signed-off-by: Yuan Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @terrytangyuan, this is a good update.
Could you also update the examples readme with the new horizontal logos: https://github.com/terrytangyuan/cncf-artwork/blob/update-logo/examples/incubating.md#kserve-logos
Signed-off-by: Yuan Tang <[email protected]>
|
Updated. Thanks! |
|
@jberkus Could you help take a look at the question above whenever you get a chance? |
|
Probably not intentional, which specific files are you asking about? |
|
projects/kserve/black/k-serve-black-horiz.png and projects/kserve/black/k-serve-black-horiz.svg |
|
hard to see against the white background of the GitHub UI, easier against the black of the screen cap i shared -- if you make it a bit bigger :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes as per Josh's comment.
|
Non-professional comment - I cannot think of a use case of |
|
It's mostly for swag. There are times when we need to do 2-color swag. |
|
Swag and future-proofing :) |
|
@terrytangyuan I've opened a PR against knative/artwork |
Signed-off-by: Yuan Tang <[email protected]>
|
Thanks. I synced changes from kserve/artwork#8 to this repo. PTAL @nate-double-u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the updates @terrytangyuan & @jberkus!

This includes enhancements in kserve/artwork#3 and the new horizontal format added in kserve/artwork#7.
Pre-submission checklist:
If you're adding a new project to the repo, please confirm each of these actions has been completed:
Note: Updates to this repo require two approvals to be merged in. One from a CNCF staff member, and the other from a project maintainer whose project's artwork is being updated. We can bypass branch protections for PRs made by maintainers.