-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(local-explorer-ui): Refactor KV & sidebar to use route loaders #12779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+147
−98
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a5c3f6c
Refactor KV & sidebar to use route loaders
NuroDev d8082dc
Minor doc comment cleanup
NuroDev 340872a
Added changeset
NuroDev 599dc84
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev f83a956
Minor code cleanup
NuroDev 4e89cd8
Updated changeset description
NuroDev d1917fd
Added missing `setLoadingMore(false)` to "onLoad" effects
NuroDev 1f7e28c
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev 544863a
Added missing cleanup hooks to KV namespaces "onMount" effect
NuroDev 39cc7e3
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev 2fa1632
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev 58bc227
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev 4ff54ef
Downgraded changeset from `minor` to `patch`
NuroDev 70a9cbd
Pin all third-party GitHub Actions to commit SHAs (#12793)
petebacondarwin 26a2ed8
Merge branch 'main' into NuroDev/local-explorer-tanstack-router-loaders
NuroDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@cloudflare/local-explorer-ui": minor | ||
| --- | ||
|
|
||
| Refactors KV & sidebar to use route loaders. | ||
|
|
||
| This change improves the user experience of the Local Explorer dashboard by ensuring that the data used for the initial render is fetched server-side and passed down to the client. This avoids the initial flicker when loading in. Both D1 & Durable Object routes already incorporate this system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.