chore(local-explorer-ui): Refactor KV & sidebar to use route loaders#12779
Open
chore(local-explorer-ui): Refactor KV & sidebar to use route loaders#12779
Conversation
🦋 Changeset detectedLatest commit: 544863a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
NuroDev
commented
Mar 5, 2026
Comment on lines
+60
to
+66
| useEffect((): void => { | ||
| setObjects(loaderData.objects); | ||
| setCursor(loaderData.cursor); | ||
| setHasMore(loaderData.hasMore); | ||
| setError(null); | ||
| setLoading(false); | ||
| }, [loaderData]); |
Member
Author
There was a problem hiding this comment.
Note: We need this effect to ensure that when switching routes the data is revalidated.
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DEVX-2467.
This change refactors the KV routes & sidebar component (Or more specifically the root layout) to take advantage of route loaders to block page rendering until the initial data is ready.
A picture of a cute animal (not mandatory, but encouraged)