feat(local-explorer-ui): Added initial data studio plumbing#12518
feat(local-explorer-ui): Added initial data studio plumbing#12518
Conversation
🦋 Changeset detectedLatest commit: d934801 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @NuroDev's task —— View job Changeset Review
The changeset Missing experimental feature opt-in instructions: According to the changeset guidelines, "If the change collects more analytics, it should be a minor even though there is no user-visible change" and "Changesets for experimental features should include note on how users can opt in." While the changeset correctly mentions "This is an experimental WIP feature," it doesn't explain how users can actually use or access this feature. Since D1 databases now appear in the sidebar, users should know:
Suggestion: Add a brief note about how to access the local explorer (e.g., what command to run, what flag to use) or clarify that this feature is automatically available but incomplete. Everything else looks good:
Screenshot Review: This is the Local Explorer UI showing the new D1 databases sidebar. The interface looks clean and organized with KV namespaces and D1 databases properly separated. No cute animals detected, but the database icons are giving strong organized-container vibes. 📦/10 |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
packages/local-explorer-ui/src/components/studio/Explain/SQLiteExplainTab.tsx
Outdated
Show resolved
Hide resolved
packages/local-explorer-ui/src/components/studio/Explain/SQLiteExplainTab.tsx
Outdated
Show resolved
Hide resolved
…eses support Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…/frameworks (#12482) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
emily-shen
left a comment
There was a problem hiding this comment.
the studio driver code is quite dense, would it be safe to assume its pretty much alright since it is being used in the outerbase studio and stratus? if there are any specific areas you modified i can have a closer look otherwise i'll assume its alright :)
packages/local-explorer-ui/src/components/studio/Explain/SQLiteExplainTab.tsx
Show resolved
Hide resolved
| loading: boolean; | ||
| error: string | null; | ||
| currentPath: string; | ||
| d1Error: string | null; |
There was a problem hiding this comment.
should we have a single error banner? instead of making it resource specific.
i see the pr description says you made it more granular but i'm just wondering why
There was a problem hiding this comment.
Yeah I thought about this as well. The only reason I made these errors unique is so if (for whatever reason) D1 databases fail to load but KV does, you can still access your local KV namespaces and not have the sidebar just set all items to render an error.
There was a problem hiding this comment.
What about setting a single error, and returning an empty array for the problematic resource if there is an error?
emily-shen
left a comment
There was a problem hiding this comment.
approved, not crucial but the one outstanding comment is that i think it would be better to have a single unified error if we fail to fetch something in the sidebar
The first of many PRs towards fixing DEVX-2415.
Changes
lodashdependency (+types)setKVError+setD1Errorinstead of justsetError)min-h-[67px]replaced withmin-h-16.75)A picture of a cute animal (not mandatory, but encouraged)