Skip to content

Skip TurboRepo running builds in Vite playground packages#12450

Merged
jamesopstad merged 4 commits intomainfrom
james/skip-playground-builds
Feb 11, 2026
Merged

Skip TurboRepo running builds in Vite playground packages#12450
jamesopstad merged 4 commits intomainfrom
james/skip-playground-builds

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Feb 6, 2026

Rename playground build script so that the playgrounds are not built when running pnpm build from the root. They have been renamed to build:default to compose with variants e.g. build:nodejs-compat.

The playground packages are built during the tests so there's no need to build them all up front. They only include build scripts for manual testing and so they can be used as examples.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: TurboRepo change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: TurboRepo change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Latest commit: e16f90c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12450

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12450

miniflare

npm i https://pkg.pr.new/miniflare@12450

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12450

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12450

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12450

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12450

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12450

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12450

wrangler

npm i https://pkg.pr.new/wrangler@12450

commit: e16f90c

@jamesopstad jamesopstad marked this pull request as draft February 11, 2026 11:05
@jamesopstad jamesopstad force-pushed the james/skip-playground-builds branch from 505af81 to d3aa786 Compare February 11, 2026 11:19
@jamesopstad jamesopstad marked this pull request as ready for review February 11, 2026 11:27
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I guess the problem that makes this necessary is that any change to the core packages will invalidate all the playground packages.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 11, 2026
@jamesopstad
Copy link
Contributor Author

Makes sense. I guess the problem that makes this necessary is that any change to the core packages will invalidate all the playground packages.

Yes. Also, the packages are built as part of the tests so there's no need to build them up front. They only include build scripts for manual testing and so they can be used as examples. Updated the description to reflect this.

@jamesopstad jamesopstad force-pushed the james/skip-playground-builds branch 2 times, most recently from 757b714 to 4de7747 Compare February 11, 2026 12:39
@jamesopstad jamesopstad force-pushed the james/skip-playground-builds branch from 4de7747 to e16f90c Compare February 11, 2026 13:35
@jamesopstad jamesopstad requested a review from ascorbic February 11, 2026 13:36
@jamesopstad jamesopstad merged commit b7cf337 into main Feb 11, 2026
41 of 42 checks passed
@jamesopstad jamesopstad deleted the james/skip-playground-builds branch February 11, 2026 14:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants