Revert 10805 (Drop process polyfill when v2 is available)#10860
Merged
edmundhung merged 4 commits intomainfrom Oct 3, 2025
Merged
Revert 10805 (Drop process polyfill when v2 is available)#10860edmundhung merged 4 commits intomainfrom
edmundhung merged 4 commits intomainfrom
Conversation
This reverts commit d0801b1.
🦋 Changeset detectedLatest commit: 9a6f7f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10855
Astro detects Node with:
With
unenvprocess wouldtoStringas[object Object]andisNodeisfalse.The the v2 implementation from @guybedford it
toStringas[object process]to match the Node implementation (this is correct) soisNodebecomestrueHowever, when Node is detected, Astro construct a response from an
AsyncIterable:But we know that workerd behavior does not conform to Node here, see cloudflare/workerd#2746. Fixing that issue would solve the Astro issue (i.e. we could drop the process polyfill).
However we will revert the PR dropping the polyfill for now.
Notes:
It looks like sentry is also using the same
isNodecheck - we should inspect commonly used packages before dropping theprocesspolyfill again.There are a couples of additional changes on top of the revert:
process.toStringwas updated