Skip to content

Drop node:process polyfill when v2 is available#10805

Merged
vicb merged 4 commits intomainfrom
vicb/process-v2-2
Sep 29, 2025
Merged

Drop node:process polyfill when v2 is available#10805
vicb merged 4 commits intomainfrom
vicb/process-v2-2

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Sep 29, 2025

The native implementation of process v2 has now all the required APIs so we can drop the polyfill.

Depends on:

Note that the event APIs used to be available on import module from "node:module" while they should not have been, this is an error in unenv.

Thanks @guybedford for the implementation in workerd.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Documented by the runtime team
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: unenv changes are not backported

@vicb vicb requested a review from a team as a code owner September 29, 2025 11:34
@vicb vicb requested a review from a team September 29, 2025 11:34
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2025

🦋 Changeset detected

Latest commit: d71a85b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 29, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10805

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10805

miniflare

npm i https://pkg.pr.new/miniflare@10805

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10805

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10805

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10805

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10805

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10805

wrangler

npm i https://pkg.pr.new/wrangler@10805

commit: d71a85b

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 29, 2025
@vicb vicb force-pushed the vicb/process-v2-2 branch from 02f8363 to a57476a Compare September 29, 2025 12:53
@vicb vicb merged commit d0801b1 into main Sep 29, 2025
40 of 42 checks passed
@vicb vicb deleted the vicb/process-v2-2 branch September 29, 2025 15:14
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 29, 2025
vicb added a commit that referenced this pull request Oct 3, 2025
edmundhung pushed a commit that referenced this pull request Oct 3, 2025
* Revert "Drop `node:process` polyfill when v2 is available (#10805)"

This reverts commit d0801b1.

* fixup! updates

* fixup! lock file

* fixup! changeset
vicb added a commit that referenced this pull request Feb 2, 2026
vicb added a commit that referenced this pull request Feb 2, 2026
vicb added a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants