Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-eagles-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/quick-edit": minor
---

Bump base VSCode version for Quick Edit & Playground to 1.102.1
11 changes: 6 additions & 5 deletions .github/workflows/deploy-pages-previews.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ jobs:
if: github.repository_owner == 'cloudflare' && github.head_ref != 'main' && (contains(github.event.*.labels.*.name, 'preview:chrome-devtools-patches') || contains(github.event.*.labels.*.name, 'preview:quick-edit') || contains(github.event.*.labels.*.name, 'preview:workers-playground'))
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
runs-on: ubuntu-22.04
group: ${{ github.workflow }}-${{ github.ref }}-app-previews
runs-on: macos-latest-large
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand All @@ -44,6 +43,8 @@ jobs:

- name: Install Dependencies
uses: ./.github/actions/install-dependencies
with:
node-version: 22
Comment on lines +46 to +47
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required by VSCode's build process


- name: Build tools and libraries
run: pnpm run build
Expand All @@ -64,11 +65,11 @@ jobs:

- name: Build and Deploy Quick Edit preview
if: contains(github.event.*.labels.*.name, 'preview:quick-edit')
# Quick Edit requires yarn and VS Code build deps, so needs fairly specific logic
run: pnpm --filter quick-edit run deploy
run: pnpm --filter quick-edit run preview
env:
DEBIAN_FRONTEND: noninteractive
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
NODE_OPTIONS: "--max_old_space_size=30000"

- name: Deploy Workers Playground preview
if: contains(github.event.*.labels.*.name, 'preview:workers-playground')
Expand Down
18 changes: 11 additions & 7 deletions packages/quick-edit-extension/src/cfs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,20 @@ declare module "*.bin" {
}
}
}
await this.writeFile(Uri.parse(`${this.rootFolder}/${path}`), contents, {
create: true,
overwrite: true,
suppressChannelUpdate: true,
readOnly: files.readOnly,
});
await this.writeFile(
Uri.parse(`cfs:/${this.rootFolder}/${path}`),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously missing the cfs:/ scheme. It worked in the older version of VSCode, but not in the newest. This took hours of stepping through compiled VSCode sources to find 😅

contents,
{
create: true,
overwrite: true,
suppressChannelUpdate: true,
readOnly: files.readOnly,
}
);
}
if (this.readRoot !== null) {
await this.readRoot(
await this.readDirectory(Uri.parse(`${this.rootFolder}/`))
await this.readDirectory(Uri.parse(`cfs:/${this.rootFolder}/`))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

);
}
}
Expand Down
Loading
Loading