Bump base VSCode version for Quick Edit & Playground to `1.102.1` by penalosa · Pull Request #10047 · cloudflare/workers-sdk

penalosa · 2025-07-23T13:28:15Z

Bump the version of VSCode upon which we base our build of VSCode for Web, which is used in Quick Edit in the Cloudflare Dashboard as well as the Workers Playground.

How to test

Checkout this PR
Run pnpm -F "@cloudflare/quick-edit" run setup
Run pnpm -F "@cloudflare/quick-edit" run custom:build

Warning, this takes about 15 minutes
Change packages/workers-playground/src/QuickEditor/VSCodeEditor.tsx#L18 to http://localhost:8787
Run (in parallel) pnpm -F workers-playground dev and pnpm -F "@cloudflare/quick-edit" exec wrangler dev
Open http://localhost:5173/playground and play around with the editor

Tests
- Tests included
- Tests not necessary because: This package needs to be manually tested
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: no user-facing changes
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: not a wrangler change

changeset-bot · 2025-07-23T13:28:19Z

🦋 Changeset detected

Latest commit: c441fa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/quick-edit	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-07-23T13:30:28Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10047

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10047

miniflare

npm i https://pkg.pr.new/miniflare@10047

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10047

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10047

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10047

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10047

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10047

wrangler

npm i https://pkg.pr.new/wrangler@10047

commit: 45df43c

penalosa · 2025-07-23T14:26:05Z

.github/workflows/deploy-pages-previews.yml

+        with:
+          node-version: 22


This is required by VSCode's build process

.github/workflows/deploy-pages-previews.yml

penalosa · 2025-07-23T14:30:34Z

packages/quick-edit-extension/src/cfs.ts

-				readOnly: files.readOnly,
-			});
+			await this.writeFile(
+				Uri.parse(`cfs:/${this.rootFolder}/${path}`),


This was previously missing the cfs:/ scheme. It worked in the older version of VSCode, but not in the newest. This took hours of stepping through compiled VSCode sources to find 😅

penalosa · 2025-07-23T14:30:46Z

packages/quick-edit-extension/src/cfs.ts

 		if (this.readRoot !== null) {
 			await this.readRoot(
-				await this.readDirectory(Uri.parse(`${this.rootFolder}/`))
+				await this.readDirectory(Uri.parse(`cfs:/${this.rootFolder}/`))


packages/quick-edit-extension/vscode.d.ts

packages/quick-edit/patches/0003-Remove-Profile-from-Setting-SubMenu.patch

packages/quick-edit/patches/0004-Remove-Account-Extension.patch

packages/quick-edit/patches/0005-Remove-nls.patch

packages/quick-edit/patches/0006-Hide-File-Explorer-by-default.patch

packages/quick-edit/patches/0007-Better-local-workspace.patch

petebacondarwin · 2025-08-08T12:12:42Z

packages/quick-edit-extension/vscode.proposed.fileSearchProvider.d.ts

+		 *
+		 * Tips for matching in Quick Open:
+		 * With the pattern, the picker will use the file name and file paths to score each entry. The score will determine the ordering and filtering.
+		 * The scoring prioritizes prefix and substring matching. Then, it checks and it checks whether the pattern's letters appear in the same order as in the target (file name and path).


it checks and it checks

?

petebacondarwin · 2025-08-08T14:00:28Z

Also built and tested it locally. Seems fine

- Bumps quick-edit-extension and @cloudflare/quick-edit packages - Updates VSCode base version with necessary compatibility fixes - Consolidates patches for better maintainability Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>

The quick-edit-extension package is private without a deploy script, making it invalid for changesets. Only @cloudflare/quick-edit needs to be versioned as it's the deployable package. Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>

petebacondarwin · 2025-08-11T08:22:52Z

@penalosa can you look into why the Deploy Pages Previews job is failing. Is it because this is now a Worker?

penalosa · 2025-08-11T09:50:57Z

@penalosa can you look into why the Deploy Pages Previews job is failing. Is it because this is now a Worker?

To be honest, I'm now a bit stumped. The script isn't failing, it seems to be getting a SIGTERM from GitHub Actions. I thought it might be memory limit related and so bumped that, but that hasn't fixed it. Do you have any ideas?

penalosa requested a review from a team as a code owner July 23, 2025 13:28

workers-devprod added this to workers-sdk Jul 23, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jul 23, 2025

penalosa added the preview:quick-edit Trigger a quick edit preview deploy label Jul 23, 2025

penalosa commented Jul 23, 2025

View reviewed changes

petebacondarwin approved these changes Aug 8, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 8, 2025

penalosa force-pushed the penalosa/bump-vscode branch from 9c93b12 to 2a245ca Compare August 8, 2025 14:43

penalosa and others added 8 commits August 8, 2025 15:43

Bump base VSCode version to 1.102.1

1a79960

Use Node v22

b74a6e8

fix lint

63f0940

fix type

ce19cd9

fix typechecking

020f042

fix lockfile

d9e3b8c

penalosa force-pushed the penalosa/bump-vscode branch from 2a245ca to d9e3b8c Compare August 8, 2025 14:47

penalosa added 5 commits August 8, 2025 16:58

concurrency

55d04df

less &

b7f7752

more memory

5c0972d

more memory

f6a61d4

more memory

9313381

penalosa added 3 commits August 11, 2025 10:53

even more memory

cdeb394

a bit more memory

b71a1f6

a bit more memory

faaed4e

penalosa added 2 commits August 11, 2025 12:22

a bit more memory

c441fa0

a bit more memory

45df43c

penalosa merged commit a4c4c5b into main Aug 11, 2025
59 of 76 checks passed

penalosa deleted the penalosa/bump-vscode branch August 11, 2025 16:02

github-project-automation bot moved this from Approved to Done in workers-sdk Aug 11, 2025

workers-devprod mentioned this pull request Aug 11, 2025

Version Packages #10263

Merged

Conversation

penalosa commented Jul 23, 2025 • edited by petebacondarwin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penalosa Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

penalosa Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Aug 8, 2025

Uh oh!

petebacondarwin commented Aug 11, 2025

Uh oh!

penalosa commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

penalosa commented Jul 23, 2025 •

edited by petebacondarwin

Loading

changeset-bot bot commented Jul 23, 2025 •

edited

Loading

pkg-pr-new bot commented Jul 23, 2025 •

edited

Loading