Add appraisals #25
Merged
Add appraisals #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peerkleio
reviewed
Jun 3, 2025
arkalim
force-pushed
the
add-appraisals
branch
2 times, most recently
from
34f7fb8 to
4dd23b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
This PR introduces
appraisalsgem to enable testing across multipleActiveRecordversions.The Appraisals file defines three separate test environments for testing the gem against different
ActiveRecordversions. This allows us to pin dependencies for each environment independently.Why did you do it?
CI runs in this repo were failing due to the incompatibility of
ActiveRecordversions6.1and7.0with the latestconcurrent_rubyversion1.3.5. Using theAppraisalsfile, we've now pinnedconcurrent_rubyto version1.3.4forActiveRecordversions6.1and7.0.This fixed the CI error:
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::LoggerTesting