Skip to content

[GEM] Inheritance Integer Type - Ruby 3.3.8 Update #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arkalim merged 7 commits into from
Jun 4, 2025
Merged

[GEM] Inheritance Integer Type - Ruby 3.3.8 Update #23

arkalim merged 7 commits into from
Jun 4, 2025

Conversation

@arkalim
Copy link

@arkalim arkalim commented Apr 29, 2025 •
edited
Loading

What

  • Updated Ruby to v3.3.8
  • No deprecation warnings
  • Added Ruby 3.3 to the test matrix
  • Updated Bundler to v2.6.9
  • Updated gem-push workflow to set up Ruby 3.3
  • Added bundle exec appraisal install to dev test command to fix Bundler::GemfileNotFound error
  • Bumped gem version

Testing

  • CI Passes
  • Local testing works

Post-merge Steps

  • Tag the latest master v0.2.2
  • Create a new release on tag v0.2.2 which will trigger the gem-push workflow to publish the new gem version

Note: This PR is to be merged after adding the appraisal gem in #25

@arkalim arkalim self-assigned this Apr 29, 2025
@arkalim arkalim force-pushed the bei-350 branch 4 times, most recently from 1f7884c to f380fb4 Compare May 1, 2025 18:08
@arkalim arkalim changed the title Ruby 3.3.7 Update [GEM] Inheritance Integer Type - Ruby 3.3.8 Update May 1, 2025
@hype08 hype08 requested review from a team, frison and liamloxton May 8, 2025 18:51
@liamloxton
Copy link

liamloxton commented May 29, 2025

I think we should update bundler to 2.5+ as well as we discovered this is potentially necessary for Ruby 3.3.8

@arkalim arkalim force-pushed the bei-350 branch 8 times, most recently from 1912a7e to 53740a3 Compare June 2, 2025 18:00
@clio-overlord

This comment was marked as outdated.

Sign in to view
@arkalim arkalim force-pushed the bei-350 branch 4 times, most recently from 3524bc3 to 5204657 Compare June 3, 2025 14:08
@arkalim arkalim marked this pull request as ready for review June 4, 2025 19:24
@arkalim arkalim merged commit 6e426c0 into master Jun 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Drew-Goddyn Drew-Goddyn Drew-Goddyn approved these changes

@anthonyoconnorclio anthonyoconnorclio anthonyoconnorclio approved these changes

@frison frison Awaiting requested review from frison frison was automatically assigned from clio/bei

@liamloxton liamloxton Awaiting requested review from liamloxton liamloxton was automatically assigned from clio/bei

@parsahonarmand99 parsahonarmand99 Awaiting requested review from parsahonarmand99

Assignees

@arkalim arkalim

Labels

pt-ruby-3.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arkalim @liamloxton @Drew-Goddyn @anthonyoconnorclio