Skip modal prompt for deactivated users #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forum users that have not confirmed their email yet cannot see any topics, so they shouldn't be prompted to follow any. Modal will appear after the conditions are satisfied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1
The prompt should not appear for users that are not activated yet and thus cannot see any topics.
I added a simple additional condition that checks if the user is activated:
app.session.user.isEmailConfirmed()In my own testing, this is working as intended.
Please note that I should not be anywhere near PHP or JavaScript code, as I have no clue what I am doing. But the fix seems simple enough to submit as a pull request :)