Prompt modal opens for disabled users who can't follow anything

[clarkwinkelmann]

The modal will open for disabled or suspended users, as well as users who must accept new terms in FoF Terms.

But if those users try to change their follow preference for any tag, they will get a permission error.

The permissions are controlled by the FoF Follow Tags extension, so there's nothing we can change on that front.

However we could either not open the modal when this situation arises, or we could open the modal but tell the user there are no tags they can subscribe to at the moment.

I'm not sure the required permission values are exposed to the frontend. I'm also not sure whether it's always all of the tags that can be unfollowable, or only some of them. If it's the later, it could make sense to hide/disable only tags that currently can't be followed in the modal instead of hiding everything.

[nemhods]

I'm not sure if this helps, but for the specific case of user activation pending, the DOM contains a DIV:
<div classname="App-notices"><div class="Alert Alert--undefined Alert--emailConfirmation">

I'm not familiar with the rest of the flarum codebase, but maybe there is an API for "App notices"?

[nemhods]

I've dug into the source of the alert, and there is a frontend feature that could at least solve the "email not yet confirmed" state:

app.session.user.isEmailConfirmed()

Would there be any side effects if this was simply added to the modal conditions? One issue I could think of is people who have extensions installed that disable email verification on purpose.
The particular extension linked calls $event->user->activate() for every new user, but this in turn only sets the email verified boolean, so it should be safe to rely on app.session.user.isEmailConfirmed() as a metaphor for "user is activated".

To me, this use case is especially critical, since it happens on first signup - the perfect time to subscribe to topics, since if this chance is missed, some users may never return and never get any updates about forum content. It's basically a 50/50 chance if new users click on "remind me later" or "continue to forum". And very irritating too, since they see an empty modal.

I'm sorry I can't produce a PR and test - i don't have the relevant dev experience nor a proper test environment at hand. But I would be really happy if this made it in!