Modernize #664

tamird · 2024-08-01T18:31:48Z

Remove obsolete dependencies.
- abort-controller; AbortController is stable since Node 15.4.0.
Update dependencies.

Depends on clangd/node-clangd#32.

tamird · 2025-02-21T02:08:11Z

@HighCommander4 I've updated this now that @clangd/install 0.1.19 is released.

HighCommander4

Thanks for the patch!

HighCommander4 · 2025-03-25T06:39:27Z

package.json

    "icon": "icon.png",
    "engines": {
-        "vscode": "^1.65.0"
+        "vscode": "^1.75.0"


Could you specify which change(s) in this patch necessitate this bump of the minimum required vscode version?

I don't remember exactly :(

HighCommander4 · 2025-03-25T06:41:46Z

package.json

+        "vscode:prepublish": "npm run prepare && npm run esbuild -- --minify --keep-names",
        "compile": "npm run esbuild -- --sourcemap",
-        "check-ts": "tsc -noEmit -p ./",
+        "prepare": "tsc -p ./",


Why remove -noEmit? The emission of javascript is done by esbuild, so now we're doing it twice in prepublish.

Don't remember! Will revert.

HighCommander4 · 2025-03-25T06:48:48Z

src/ast.ts

  }
  getState(): vscodelc.FeatureState { return {kind: 'static'}; }
-  dispose() {}
+  clear() {}


Adding some context for my own reference / posterity: vscode-languageclient renamed the dispose() method of the StaticFeature interface to clear() in microsoft/vscode-languageserver-node#1298.

I couldn't find an explanation of why; if you happen to know, I'd be curious.

My guess is that dispose has other meaning: https://github.com/tc39/proposal-explicit-resource-management

HighCommander4 · 2025-03-25T06:57:02Z

package.json

-        "@clangd/install": "0.1.17",
-        "abort-controller": "^3.0.0",
-        "vscode-languageclient": "8.0.2"
+        "@clangd/install": "0.1.19",


I guess we need to do a new node-clangd release to pick up clangd/node-clangd@d567269 first.

Ah, I guess so. I'll bump this to 0.1.20.

Er, let me know when you've released and I'll update.

Posted clangd/node-clangd#37

HighCommander4 · 2025-03-25T07:02:29Z

src/install.ts

    });
    return Promise.resolve(result); // Thenable to real promise.
  }
+  localize(message: string, ...args: Array<string|number|boolean>): string {


Ah, nice! I forgot about this. Looks like the person who contributed this support to node-clangd only cared about having it in coc-clangd 😆

This also partially answers my question about the vscode engine version: per the original discussion at #560, localization requires 1.73.

(You can add "Fixes #560" to the commit message.)

tamird · 2025-03-25T23:20:20Z

@HighCommander4 have a look at the CI failure. Seems the great minds behind unzipper decided to add a dynamic require in ZJONSSON/node-unzipper#325 for the AWS SDK for some reason, which is inherently incompatible with esbuild.

tamird · 2025-03-25T23:34:09Z

Ah, I was able to mark it external and that seems to work.

HighCommander4 · 2025-03-26T05:23:52Z

package.json

+        "@types/mocha": "^10.0.7",
+        "@types/node": "^22.0.2",
+        "@types/sinon": "^17.0.3",
+        "@types/vscode": "1.97.0",


This seems wrong. I think this needs to match engines.vscode, because when I try to run npm run package locally, I get:

ERROR @types/vscode 1.97.0 greater than engines.vscode ^1.75.0. Either upgrade engines.vscode or use an older @types/vscode version

Matched the engine version.

- Remove obsolete dependencies. - abort-controller; `AbortController` is stable since Node 15.4.0. - Update dependencies. - @clangd/install; required as `AbortController` is part of the API surface so be the same type. Fixes clangd#560.

These are not required since VSCode 1.74.0. See https://code.visualstudio.com/api/references/activation-events#onCommand.

HighCommander4

Thanks, LGTM! CI is green and a local build is successful as well -- I'll go ahead and merge.

kadircet · 2025-05-23T10:01:30Z

package.json

    "main": "./out/bundle",
    "scripts": {
-        "esbuild": "esbuild ./src/extension.ts --bundle --outfile=out/bundle.js --external:vscode --format=cjs --platform=node",
+        "esbuild": "esbuild ./src/extension.ts --bundle --outfile=out/bundle.js --external:@aws-sdk/client-s3 --external:vscode --format=cjs --platform=node",


why do we need aws-sdk dependency here?

I believe this is saying that we don't bundle this package. I don't remember why I had to add this flag. Try removing it and see?

sent out #815

* Modernize - Remove obsolete dependencies. - abort-controller; `AbortController` is stable since Node 15.4.0. - Update dependencies. - @clangd/install; required as `AbortController` is part of the API surface so be the same type. Fixes clangd#560. * Remove redundant activation events These are not required since VSCode 1.74.0. See https://code.visualstudio.com/api/references/activation-events#onCommand.

tamird force-pushed the modernize branch 4 times, most recently from 46f3ab7 to b14fc62 Compare February 10, 2025 21:29

tamird force-pushed the modernize branch from b14fc62 to 6e8dd72 Compare February 21, 2025 02:07

HighCommander4 self-requested a review February 21, 2025 02:12

tamird force-pushed the modernize branch from 6e8dd72 to 29b737c Compare March 24, 2025 19:31

HighCommander4 reviewed Mar 25, 2025

View reviewed changes

tamird force-pushed the modernize branch 3 times, most recently from 3d509f7 to 0344527 Compare March 25, 2025 23:16

tamird force-pushed the modernize branch 2 times, most recently from 15798a0 to f540978 Compare March 25, 2025 23:25

HighCommander4 reviewed Mar 26, 2025

View reviewed changes

tamird added 2 commits March 26, 2025 06:20

Modernize

c4a8c7b

- Remove obsolete dependencies. - abort-controller; `AbortController` is stable since Node 15.4.0. - Update dependencies. - @clangd/install; required as `AbortController` is part of the API surface so be the same type. Fixes clangd#560.

Remove redundant activation events

72f2c51

These are not required since VSCode 1.74.0. See https://code.visualstudio.com/api/references/activation-events#onCommand.

tamird force-pushed the modernize branch from f540978 to 72f2c51 Compare March 26, 2025 10:23

HighCommander4 approved these changes Mar 27, 2025

View reviewed changes

HighCommander4 merged commit 16efcdc into clangd:master Mar 27, 2025
1 check passed

tamird deleted the modernize branch March 27, 2025 06:02

kadircet reviewed May 23, 2025

View reviewed changes

tamird mentioned this pull request Jun 16, 2025

Add dependabot config #663

Merged

HighCommander4 mentioned this pull request Sep 28, 2025

Extension fails to download latest clangd (21.1.0) #873

Closed

Modernize #664

Modernize #664

Uh oh!

Conversation

tamird commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tamird commented Feb 21, 2025

Uh oh!

HighCommander4 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tamird commented Mar 25, 2025

Uh oh!

tamird commented Mar 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HighCommander4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tamird commented Aug 1, 2024 •

edited

Loading