Skip to content

Conversation

@tamird
Copy link
Collaborator

@tamird tamird commented Aug 1, 2024

This will batch all updates into a single PR once a month.

Dependabot was previously removed in
995639f but this should be much less
noisy than the previous setup.

@tamird
Copy link
Collaborator Author

tamird commented Aug 6, 2024

@HighCommander4 would you mind giving this a look?

@HighCommander4 HighCommander4 self-requested a review August 6, 2024 20:09
@HighCommander4
Copy link
Contributor

HighCommander4 commented Aug 6, 2024

I added myself as a reviewer, but it will take me a while to get to, as I'm on travels right now, and I'm not really familiar with these Github Actions type things. (So if someone else would like to review it sooner, please feel free.)

@HighCommander4
Copy link
Contributor

@tamird could you elaborate on the motivation for this patch?

Is there a problem you're experiencing as a vscode-clangd user (or developer) that this patch solves for you?

This will batch all updates into a single PR once a month.

Dependabot was previously removed in
995639f but this should be much less
noisy than the previous setup.
@tamird
Copy link
Collaborator Author

tamird commented Jun 16, 2025

@HighCommander4 sorry, neglected to reply. The motivation is that it's easier to stay current incrementally rather than having to do big-bang bumps like #664.

@HighCommander4
Copy link
Contributor

@HighCommander4 sorry, neglected to reply. The motivation is that it's easier to stay current incrementally rather than having to do big-bang bumps like #664.

My thoughts here are similar to the ones in the node-clangd issue: I'd be fine with this if you're also volunteering to handle the monthly updates, otherwise I'd lean towards a more conservative configuration such as excluding major version bumps.

@tamird
Copy link
Collaborator Author

tamird commented Jun 22, 2025

Yep, I am volunteering.

@tamird
Copy link
Collaborator Author

tamird commented Jun 24, 2025

@kadircet are you able to invite me to this repo as well?

@tamird
Copy link
Collaborator Author

tamird commented Jun 25, 2025

Thanks @kadircet! Merging.

@tamird tamird merged commit 1f4e7ae into clangd:master Jun 25, 2025
1 check passed
@tamird tamird deleted the add-dependabot branch June 25, 2025 16:17
@HighCommander4
Copy link
Contributor

HighCommander4 commented Aug 11, 2025

@tamird I'm finding dependabot to be making the commit history pretty noisy. 18 of the last 22 commits are from dependabot, over the course of ~1.5 months. That's a lot more than "once a month". Do you know why there are so many, and is there something we can do to reduce the noise?

@tamird
Copy link
Collaborator Author

tamird commented Aug 11, 2025

The ones that aren't on the normal cadence are typically security-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants