Add jsonschema for the events #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
force-pushed
the
schemas
branch
2 times, most recently
from
4b40f83 to
a3d2639
Compare
afrittoli
changed the title
Contributor
e-backmark-ericsson
left a comment
e-backmark-ericsson
left a comment
There was a problem hiding this comment.
Provided some comments for artifactpackaged.json. Some of those are valid for all event types more or less.
Add initial jsonschemas for all of the events. These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
Signed-off-by: Andrea Frittoli <[email protected]>
e-backmark-ericsson
approved these changes
Sep 7, 2022
Contributor
e-backmark-ericsson
left a comment
e-backmark-ericsson
left a comment
There was a problem hiding this comment.
Haven't reviewed this in too much detail for each event type, but overall it looks good so it would be ok to merge as a first version of the schemas.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial jsonschemas for all of the events.
These json schemas are automatically generated through the
go types defined in the new cdevents/go-sdk, using the
library github.com/invopop/jsonschema, see
cdevents/sdk-go#6 for details.
Signed-off-by: Andrea Frittoli [email protected]