Add support for jsonschemas #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to generate jsonschemas from the golang structs. Generate jsonschemas for existing events, and use them to validate test data in JSON format. Signed-off-by: Andrea Frittoli <[email protected]>
Contributor
Author
|
This mostly works well, there is only one issue to solve on the validation side. Right now when doing validate the type of CDEvent object does not match what the validator expects for some reason. A trick is to marshal the CDEvent to json, unmarshal it back using a generic |
afrittoli
added a commit
to afrittoli/cdevents-spec
that referenced
this pull request
Aug 23, 2022
Add initial jsonschemas for some of the events: - taskrun - pipelinerun - change These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
Producing a cloudevent or json does not require changing the event, so using the reader interface instead. Signed-off-by: Andrea Frittoli <[email protected]>
The omitempty struct tag is interpreted by the schema generation library like a non-required field, so we cannot set "omitempty" on required fields, else the schema will be invalid. To solve the issue, use instead minLenght tags for all string required fields, to indicate that a non-empty value must be provided for validation to pass. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
changed the title
Contributor
Author
|
Found a solution in using |
afrittoli
added a commit
to afrittoli/cdevents-spec
that referenced
this pull request
Aug 24, 2022
Add initial jsonschemas for some of the events: - taskrun - pipelinerun - change These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
added a commit
to afrittoli/cdevents-spec
that referenced
this pull request
Aug 25, 2022
Add initial jsonschemas for all of the events. These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
added a commit
to cdevents/spec
that referenced
this pull request
Sep 6, 2022
Add initial jsonschemas for all of the events. These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
added a commit
to cdevents/spec
that referenced
this pull request
Sep 13, 2022
* Add jsonschema for a few of the events Add initial jsonschemas for all of the events. These json schemas are automatically generated through the go types defined in the new cdevents/go-sdk, using the library github.com/invopop/jsonschema, see cdevents/sdk-go#6 for details. Signed-off-by: Andrea Frittoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to generate jsonschemas from the golang structs.
Generate jsonschemas for existing events, and use them to validate
test data in JSON format.
Signed-off-by: Andrea Frittoli [email protected]