Skip to content

test with go 1.21 and 1.22 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

test with go 1.21 and 1.22 #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ jobs:
coverage:
runs-on: ubuntu-latest

strategy:
matrix:
go-version:
- '1.21'
- '1.22'
Comment on lines +22 to +24
Copy link
Contributor

@afrittoli afrittoli Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Should we add this in the other workflows too, or do you think coverage is enough since this will run unit tests?

Copy link
Contributor Author

@cpanato cpanato Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think only here is enough, the CI one is checking the lint; maybe we upgrade that to 1.22 directly

Copy link
Contributor

@afrittoli afrittoli Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that the coverage report for 1.22 will override that of 1.21, but that's fine since codecov only expects one version of the coverage output for a PR.

Copy link
Contributor Author

@cpanato cpanato Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make to ignore that, let me know if you want that then i will update it


env:
GOPATH: /home/runner/go

Expand All @@ -29,7 +35,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
with:
go-version: '1.21'
go-version: ${{ matrix.go-version }}
check-latest: true

- name: Generate coverage report
Expand Down