Skip to content

Conversation

@cpanato
Copy link
Contributor

@cpanato cpanato commented Jul 10, 2024

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (080d904) to head (5ebcd91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   82.29%   81.80%   -0.50%     
==========================================
  Files         101      102       +1     
  Lines        8028     8077      +49     
==========================================
  Hits         6607     6607              
- Misses       1196     1245      +49     
  Partials      225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +22 to +24
go-version:
- '1.21'
- '1.22'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Should we add this in the other workflows too, or do you think coverage is enough since this will run unit tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think only here is enough, the CI one is checking the lint; maybe we upgrade that to 1.22 directly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that the coverage report for 1.22 will override that of 1.21, but that's fine since codecov only expects one version of the coverage output for a PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make to ignore that, let me know if you want that then i will update it

@afrittoli afrittoli added this pull request to the merge queue Jul 15, 2024
Merged via the queue into cdevents:main with commit 5792dda Jul 15, 2024
@cpanato cpanato deleted the test-with-go-122-21 branch July 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants