-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add missing conversion class from vector of WheelTelemetryData to Python list #8078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BBArikL
wants to merge
547
commits into
carla-simulator:dev
from
BBArikL:fix_wheel_telemetry_data_access
Closed
Add missing conversion class from vector of WheelTelemetryData to Python list #8078
BBArikL
wants to merge
547
commits into
carla-simulator:dev
from
BBArikL:fix_wheel_telemetry_data_access
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement package generation for windows * Prevent unreal editor to ve launched when finish the package
* First implementation * Small fixes
Co-authored-by: Xavier Solé Nogués <[email protected]>
Co-authored-by: Xavier Solé Nogués <[email protected]>
Co-authored-by: Xavier Solé Nogués <[email protected]>
* Added spawnning all vehicles and all walkers * Update tests, and add begin play to avoid initialization error in vehicles * Adding test list and tested tests * Update PythonAPI/test/API/spawn_vehicles.py Co-authored-by: Xavier Solé Nogués <[email protected]> * Update PythonAPI/test/API/collision_test.py Co-authored-by: Xavier Solé Nogués <[email protected]> * Update PythonAPI/test/API/spawn_walkers.py Co-authored-by: Xavier Solé Nogués <[email protected]> * Update files names * Updated TestCollision * Adding sync mode test * Updated test not to use eggs and updated copyright * Update sync test * Update sync test vehicle/walkers test --------- Co-authored-by: Xavier Solé Nogués <[email protected]>
This reverts commit 82d090e.
This reverts commit b7e7046.
Fixed path naming inconsistencies in Python scripts
* fixed build links * typo * type
* fixed build links * typo * type * fixed remaining links
* fixed build links * typo * type * fixed remaining links * added furnther build instructions * updated links * bracket typo * visual studio * added github credentials instructions * reference env command * updated with sudo commands * cleaned unattended instructions
* Upgrade CarlaSetup.sh. * More setup script changes. * Separate prerequisites install from main CarlaSetup.sh * Minor fixes. * More fixes, added separate launch option. * Fix incorrect credentials prompt. * Minor fix.
|
A mistake has been made. |
|
The fixed PR is here : #8560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing conversion class from vector of WheelTelemetryData to Python list
This adds a missing conversion from vector of WheelTelemetryData to a Python list. When trying to access the "wheels" attribute of the VehicleTelemetryData without this, this exception will occur:
TypError: No to_python (by-value) converter found for C++ type: std::vector<carla::rpc::WheelTelemetryData, std::allocatorcarla::rpc::WheelTelemetryData>
This addition fixes this issue to make the usage in line with similar classes such as "VehiclePhysicsControl" and "WheelPhysicsControl"
Checklist:
devbranch and tested with latest changesmake check(only Linux)Where has this been tested?
This change is