Skip to content

Fix daily reward eligibility to use configurable calendar days instead of 24-hour intervals #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caprapaul merged 3 commits into from
Sep 2, 2025
Merged

Fix daily reward eligibility to use configurable calendar days instead of 24-hour intervals #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcebcaf
Initial plan
Copilot Sep 2, 2025
3d0ed6f
Update daily reward logic to use calendar days instead of interval se…
Copilot Sep 2, 2025
eb1e749
Rename CasinoDailyRewardIntervalSeconds to CasinoDailyRewardIntervalD…
Copilot Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DiscordBot/Services/Casino/CasinoService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ public bool IsChannelAllowed(ulong channelId)
{
var user = await GetOrCreateCasinoUser(userId);
var now = DateTime.UtcNow;
var nextRewardTime = user.LastDailyReward.AddSeconds(_settings.CasinoDailyRewardIntervalSeconds);
var nextRewardTime = user.LastDailyReward.Date.AddDays(_settings.CasinoDailyRewardIntervalDays);

if (now < nextRewardTime)
{
Expand All @@ -335,7 +335,7 @@ public bool IsChannelAllowed(ulong channelId)
await RecordTransaction(userId, (long)tokensAwarded, TransactionType.DailyReward);

await _loggingService.LogChannelAndFile($"{ServiceName}: User {userId} claimed daily reward of {tokensAwarded} tokens");
return (true, tokensAwarded, newBalance, now.AddSeconds(_settings.CasinoDailyRewardIntervalSeconds));
return (true, tokensAwarded, newBalance, now.Date.AddDays(_settings.CasinoDailyRewardIntervalDays));
}
catch (Exception ex)
{
Expand All @@ -348,7 +348,7 @@ public bool IsChannelAllowed(ulong channelId)
public async Task<DateTime> GetNextDailyRewardTime(string userId)
{
var user = await GetOrCreateCasinoUser(userId);
return user.LastDailyReward.AddSeconds(_settings.CasinoDailyRewardIntervalSeconds);
return user.LastDailyReward.Date.AddDays(_settings.CasinoDailyRewardIntervalDays);
}

#endregion
Expand Down
2 changes: 1 addition & 1 deletion DiscordBot/Settings/Deserialized/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public class BotSettings

// Daily Reward Settings
public ulong CasinoDailyRewardTokens { get; set; } = 100;
public int CasinoDailyRewardIntervalSeconds { get; set; } = 86400; // 24 hours = 86400 seconds
public int CasinoDailyRewardIntervalDays { get; set; } = 1; // Number of days between rewards

#endregion // Casino Settings

Expand Down