Fix daily reward eligibility to use configurable calendar days instead of 24-hour intervals

[Copilot]

This PR updates the daily reward system in CasinoService to use calendar day-based eligibility with a configurable interval instead of fixed 24-hour periods.

Problem

Previously, users had to wait exactly 24 hours from their last daily reward claim before becoming eligible again. This meant:

• A user claiming at 11 PM would have to wait until 11 PM the next day
• Users in different time zones had varying optimal claim times
• The system felt less intuitive than typical "daily" mechanics
• The interval was hardcoded to 1 day and not configurable by server admins

Solution

The logic now compares calendar dates instead of time intervals and uses a configurable setting for the number of days:

// Before: 24-hour interval from last claim
var nextRewardTime = user.LastDailyReward.AddSeconds(_settings.CasinoDailyRewardIntervalSeconds);

// After: Configurable number of calendar days after last claim
var nextRewardTime = user.LastDailyReward.Date.AddDays(_settings.CasinoDailyRewardIntervalDays);

Changes Made

• TryClaimDailyReward: Updated eligibility check to use user.LastDailyReward.Date.AddDays(_settings.CasinoDailyRewardIntervalDays)
• TryClaimDailyReward: Updated return value to use now.Date.AddDays(_settings.CasinoDailyRewardIntervalDays) for consistent calendar logic
• GetNextDailyRewardTime: Updated to use configurable interval setting
• Settings: Renamed CasinoDailyRewardIntervalSeconds to CasinoDailyRewardIntervalDays with default value of 1

Impact

Users can now claim their daily reward once per configurable calendar day period (UTC), providing a more intuitive and flexible experience:

• Claiming at 11 PM allows the next claim at 12 AM (1 hour later) when set to 1 day
• All users become eligible at the same UTC midnight boundary
• Server admins can configure the interval (e.g., daily=1, every 2 days=2, weekly=7)
• Maintains the "once per period" restriction while improving user experience

This change is backward compatible with existing database schemas and user data.

This pull request was created as a result of the following prompt from Copilot chat.

Update TryClaimDailyReward in CasinoService so daily reward eligibility is checked by calendar day instead of interval seconds. Compare now.Date and user.LastDailyReward.Date, and set nextRewardTime to the start of the next calendar day after the last claim. Use nextRewardTime in both the eligibility check and the return value. The updated logic should look like:

var now = DateTime.UtcNow;
var nextRewardTime = user.LastDailyReward.Date.AddDays(1);
if (now < nextRewardTime)
{
// User has already claimed today
return (false, 0, user.Tokens, nextRewardTime);
}
// User can claim daily reward
// ... (rest unchanged)

This ensures users can claim their reward once per calendar day. All usages of the old interval-based logic should be replaced. Target the fork source branch for the PR.

References:
https://github.com/caprapaul/UDC-Bot/blob/master/DiscordBot/Services/Casino/CasinoService.cs#L318

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[caprapaul]

@copilot Can you make the existing setting be used for the number of days? Also rename it from CasinoDailyRewardIntervalSeconds to CasinoDailyRewardIntervalDays

[Copilot]

@copilot Can you make the existing setting be used for the number of days? Also rename it from CasinoDailyRewardIntervalSeconds to CasinoDailyRewardIntervalDays

Done! I've renamed CasinoDailyRewardIntervalSeconds to CasinoDailyRewardIntervalDays and updated all the hardcoded AddDays(1) calls to use _settings.CasinoDailyRewardIntervalDays. The default value is now 1 day, but server admins can configure it to any number of days (e.g., 2 for every 2 days, 7 for weekly rewards). Commit eb1e749

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.myget.org
  • Triggering command: dotnet build --no-restore (dns block)
  • Triggering command: dotnet restore (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)