Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wsl-bau #16161 +/- ##
========================================
Coverage 47.75% 47.75%
========================================
Files 37 37
Lines 5801 5801
========================================
Hits 2770 2770
Misses 3031 3031 🚀 New features to boost your workflow:
|
|
@mattea-turic @Sophie-32 This is ready for design and UX review. Thanks! |
|
Thanks @steverydz for your work on this page! Looks good :) Comments:"Ubuntu is the number 1 choice..."
"Latest Ubuntu on WSL news from our blog"
|
005bfab to
d9c6a6d
Compare
|
@mattea-turic I've made the 50-50 update and managed to get the blog macro working with the linked heading. The only thing is that I can't get rid of the author/date section for each post. Is it ok to keep them there? |
No worries, we can keep them there! Is author & date required as part of the macro – because if so, I'll raise a ticket to have these as optional
+1 ing for design |
|
@mattea-turic Yes, the author/date section is baked into the blog macro. The only configurable options are the title text and number of articles. What do you mean using deep padding? The whole blog section here is what the blog macro provides so I can't affect any spacing within that. |
Just to wrap it in a deep section, as the last sections on our pages should all have 128 px bottom padding (right now it seems to be the default 64 px)
Thanks for the info ! |
d9c6a6d to
f62e4e0
Compare
Jumping in at request of @kim-isaac - author & date are currently optional for Static blog patterns but (in practice) not optional for Dynamic blog patterns, there was an oversight in the creation of the dynamic version that causes author/date to always be rendered. Details hereArticle block creates a slot for author & date & Sites' latest-news module automatically populates author and time if present. Because the Blog API always has a date & author for each article, the date & author are always rendered. To make metadata (or, more granularly, author/date) optional we would need a simple change to conditionally render the metadata slot, or the author/time elements here - that way the Latest News module skips populating Author & date. |
|
Hi @steverydz, looking at the demo I see that we've duplicated 2 of the links in the second section, unlike the Figma & copydoc. |
f62e4e0 to
17e0905
Compare
|
@thisisrichardferreira Good catch. Fixed! |
huwshimi
left a comment
There was a problem hiding this comment.
A few tiny fixes. I'll give this "+1 with changes" as those changes don't need another review.
templates/wsl/organizations.html
Outdated
|
|
||
| {%- if slot == 'list_item_description_1' -%} | ||
| <p> | ||
| Get up to 15 years of security patches for Ubuntu on WSL through Expanded Security Maintenance (ESM), with coverage for thousands of community-sourced packages from Ubuntu software repositories. |
There was a problem hiding this comment.
It looks like "(ESM)" has a link in the design and copy doc.
| Get up to 15 years of security patches for Ubuntu on WSL through Expanded Security Maintenance (ESM), with coverage for thousands of community-sourced packages from Ubuntu software repositories. | |
| Get up to 15 years of security patches for Ubuntu on WSL through Expanded Security Maintenance (<a href="https://ubuntu.com/security/esm">ESM</a>), with coverage for thousands of community-sourced packages from Ubuntu software repositories. |
templates/wsl/organizations.html
Outdated
|
|
||
| {%- if slot == 'cta' -%} | ||
| <a href="/wsl#get-in-touch" class="p-button js-invoke-modal" aria-controls="contact-modal" aria-expanded="false"> | ||
| Contact us › |
There was a problem hiding this comment.
The design doesn't have the arrow in this button.
| Contact us › | |
| Contact us |
templates/wsl/organizations.html
Outdated
| {% extends "templates/base.html" %} | ||
|
|
||
| {% block meta_copydoc %} | ||
| https://docs.google.com/document/d/1M7e2B08GgPA7K6Wx0ThE6s9_xQINM0MSkarfdKUTEYI/edit# |
There was a problem hiding this comment.
| https://docs.google.com/document/d/1M7e2B08GgPA7K6Wx0ThE6s9_xQINM0MSkarfdKUTEYI/edit# | |
| https://docs.google.com/document/d/1E7ycafq7TujOeCkZqO3-sGhyFaU802NlliPCCDOR-kw/edit?tab=t.jijjhiya0no5 |
17e0905 to
98fa666
Compare


Done
Adds /wsl/organizations page
QA
Issue / Card
Fixes WD-34489
Screenshots
Help
QA steps - Commit guidelines