Skip to content

rewrite: Avoid panic on bad arg count for uri #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francislavoie merged 2 commits into from
Sep 13, 2024
Merged

rewrite: Avoid panic on bad arg count for uri #6571

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
087425a
avoid OOB slice access in parseCaddyfileURI when invalid config
mister-turtle Sep 13, 2024
bb0d17f
Changed to bounds checks on strip_prefix and strip_suffix, other case…
mister-turtle Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/caddyhttp/rewrite/caddyfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func parseCaddyfileURI(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, err
h.Next() // consume directive name

args := h.RemainingArgs()
if len(args) < 1 {
if len(args) <= 1 {
Comment thread
francislavoie marked this conversation as resolved.
Outdated
return nil, h.ArgErr()
}

Expand Down