rewrite: Avoid panic on bad arg count for uri#6571
Merged
francislavoie merged 2 commits intocaddyserver:masterfrom Sep 13, 2024
Merged
rewrite: Avoid panic on bad arg count for uri#6571francislavoie merged 2 commits intocaddyserver:masterfrom
uri#6571francislavoie merged 2 commits intocaddyserver:masterfrom
Conversation
All cases for args[0] require additional arguments present in the slice so doing the bounds check here covers all cases. Cases requiring additional parameters already include additional checks on the len(args)
|
|
francislavoie
changed the title
uri
…s already seem to have bounds checks in place.
francislavoie
approved these changes
Sep 13, 2024
Member
francislavoie
left a comment
francislavoie
left a comment
There was a problem hiding this comment.
Thanks!
(The lint errors aren't your fault, false-positives we're still dealing with separately)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All cases for args[0] require additional arguments present in the slice so doing the bounds check here covers all cases. Cases requiring additional parameters already include additional checks on the len(args)