Fix WebXR handedness search for gamepad-controls #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least in the current version of the WebXR spec, `handedness` is a property of XRInputSource (`xrController`), rather than Gamepad.
Contributor
|
I have built dist with this change in my own fork and can confirm that it fixes the issue on Quest 2 Live example: https://glitch.com/edit/#!/enormous-fire-shop |
|
Could this PR be merged, please? Or let us know why not. |
Member
|
This PR is merged in the community fork #5 |
Member
|
The changes are now also in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in the current version of the WebXR spec,
handednessis a property of XRInputSource (xrController), rather than Gamepad.This leads to an issue discussed on the WebXR Discord chat (https://discord.com/channels/758943204715659264/759166287901098024/856977980219981844) where the controls attach to the wrong hand, even when the correct hand shows up later.