Skip to content

Update preview2-prototyping download links #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 2 commits into from
Jun 28, 2023
Merged

Update preview2-prototyping download links #577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e84b08
Update preview2-prototyping download links
danbev May 14, 2023
30f8d3c
Change component adapter links to point to wasmtime
danbev Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ which has a `_start` entrypoint (e.g. a `src/main.rs` in Rust).

[preview2-prototyping]: https://github.com/bytecodealliance/preview2-prototyping
[preview1-build]: https://github.com/bytecodealliance/preview2-prototyping/releases/tag/latest
[non-command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_snapshot_preview1.reactor.wasm
[command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_snapshot_preview1.command.wasm
[non-command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.reactor.wasm
[command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.command.wasm
Copy link
Copy Markdown
Contributor

@rylev rylev Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[non-command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.reactor.wasm
[command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.command.wasm
[non-command]: https://github.com/bytecodealliance/wasmtime/releases/download/v10.0.1/wasi_snapshot_preview1.reactor.wasm
[command]: https://github.com/bytecodealliance/wasmtime/releases/download/v10.0.1/wasi_snapshot_preview1.command.wasm

Unfortunately, wasmtime doesn't have a "latest" tag, so we would have to update this on each wasmtime release, or we should open an issue on the wasmtime repo to add a latest tag.

Copy link
Copy Markdown
Contributor

@pchickey pchickey Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the latest behavior is a github http redirect: https://github.com/bytecodealliance/wasmtime/releases/latest redirects to https://github.com/bytecodealliance/wasmtime/releases/tag/v10.0.1 at the moment

Copy link
Copy Markdown
Contributor Author

@danbev danbev Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions! I've updated this PR now with a commit that uses latest like @pchickey suggested.


## Supported Guest Languages
[guests]: #supported-guest-languages
Expand Down