Update preview2-prototyping download links#577
Update preview2-prototyping download links#577alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This commit updates the preview2-prototyping command and reactor .wasm download links as they have been updated. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Thanks! I would prefer to point these at the wasmtime repo once it lands there - I expect we will finish that tomorrow. bytecodealliance/wasmtime#6374 |
| [non-command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.reactor.wasm | ||
| [command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.command.wasm |
There was a problem hiding this comment.
| [non-command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.reactor.wasm | |
| [command]: https://github.com/bytecodealliance/preview2-prototyping/releases/download/latest/wasi_preview1_component_adapter.command.wasm | |
| [non-command]: https://github.com/bytecodealliance/wasmtime/releases/download/v10.0.1/wasi_snapshot_preview1.reactor.wasm | |
| [command]: https://github.com/bytecodealliance/wasmtime/releases/download/v10.0.1/wasi_snapshot_preview1.command.wasm |
Unfortunately, wasmtime doesn't have a "latest" tag, so we would have to update this on each wasmtime release, or we should open an issue on the wasmtime repo to add a latest tag.
There was a problem hiding this comment.
I believe that the latest behavior is a github http redirect: https://github.com/bytecodealliance/wasmtime/releases/latest redirects to https://github.com/bytecodealliance/wasmtime/releases/tag/v10.0.1 at the moment
There was a problem hiding this comment.
Thanks for the suggestions! I've updated this PR now with a commit that uses latest like @pchickey suggested.
This commit updates the link to the component adapters to point to the wasmtime repository instead of preview2-prototyping. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
4 participants
This commit updates the preview2-prototyping command and reactor .wasm download links as they have been updated.