Skip to content

Fix examples for chain_redesign_tx_graph_anchor#941

Closed
notmandatory wants to merge 2 commits intobitcoindevkit:masterfrom
notmandatory:chain_redesign_tx_graph_anchor
Closed

Fix examples for chain_redesign_tx_graph_anchor#941
notmandatory wants to merge 2 commits intobitcoindevkit:masterfrom
notmandatory:chain_redesign_tx_graph_anchor

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Apr 16, 2023

Description

WIP fix examples for #926.

Building off of @danielabrozzoni's bdk_nakamoto branch changes.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Apr 16, 2023
@notmandatory notmandatory changed the title Fix examples for chain redesign tx graph anchor Fix examples for chain_redesign_tx_graph_anchor Apr 16, 2023
@evanlinjin
Copy link
Member

evanlinjin commented Apr 22, 2023

Thank you for the work so far, I've progressed on this here: 45d376a (part of #943).

I've decided to create a new module example-crates/tracker_example_cli which is a duplicate of example-crates/keychain_tracker_example_cli, but uses the redesigned structures.

@notmandatory notmandatory force-pushed the chain_redesign_tx_graph_anchor branch from 9b6b1d3 to 9c859a8 Compare April 22, 2023 20:55
@notmandatory notmandatory added this to the 1.0.0-alpha.1 milestone Apr 22, 2023
@notmandatory notmandatory force-pushed the chain_redesign_tx_graph_anchor branch from 9c859a8 to ef4927e Compare April 29, 2023 15:39
@notmandatory
Copy link
Member Author

Closing this PR and starting over for only esplora examples based on work started in #943.

@notmandatory notmandatory removed this from the 1.0.0-alpha.1 milestone May 6, 2023
@notmandatory notmandatory deleted the chain_redesign_tx_graph_anchor branch May 23, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants