Introduce redesigned `bdk_chain` structures by evanlinjin · Pull Request #926 · bitcoindevkit/bdk

evanlinjin · 2023-03-24T01:30:13Z

Description

This is part of #895

The initial bdk_chain structures allowed updating to be done without blocking IO (alongside many other benefits). However, the requirement to have transactions "perfectly positioned" in our SparseChain increased complexity of the syncing API. Updates needed to be meticulously crafted to properly connect with the original SparseChain. Additionally, it forced us to keep a local copy of the "best chain" data (which may not always be needed depending on the chain source).

The redesigned structures, as introduced by this PR, fixes these shortcomings.

Instead of SparseChain, we introduce the ability to Anchor a transaction to multiple blocks that may or may not be in the same chain history. We expand TxGraph to records these anchors (while still maintaining the monotone nature of TxGraph). When updating our new TxGraph, we don't need to complicated are-we-connected checks that we need for SparseChain.
The chain source, in combination with our newTxGraph is all that we need to determine the "chain position" of a transaction. The chain source only needs to implement a single trait ChainOracle. This typically does not need to be updated (as it is remote), although we can have a special ChainOracle implementation that is stored locally. This only needs block height and hash information, reducing the scope of non-monotine structures that need to be updated.

What is done:

TxGraph includes anchors (ids of blocks that the tx is seen in) and last-seem unix timestamp (for determining which non-confirmed tx we should consider as part of "best chain" if there are conflicts). This structure continues to be fully "monotone"; we can introduce data in any manner and not risk resulting in an inconsistent state.
LocalChain includes the "checkpoint" logic of SparseChain but removes the txid data. LocalChain implements the ChainOracle trait. Any blockchain-source can also implement the ChainOracle trait.
IndexedTxGraph is introduced and contains two fields; an internal TxGraph struct and a TxIndex implementation. These two fields will be updated atomically and can replace the functionality of keychain::Tracker.

What is in-progress:

@evanlinjin: The TxIndex trait should not have is_{}_relevant methods as we cannot guarantee this across all transaction indexes. We should introduce extension traits for these (Introduce redesigned bdk_chain structures #926 (comment)).
@evanlinjin: BlockAnchor should be defined as "if this block is in chain, then this tx must be in chain". Therefore, the anchor does not provide us with the exact confirmation height of the tx. We need to introduce an extension trait ExactConfirmationHeightAnchor for certain operations (Introduce redesigned bdk_chain structures #926 (comment)).

What will be done external to this PR:

@rajarshimaitra: Persisting indexed_tx_graph::Additions (Update persistance With new IndexedTxGraph #937).
@notmandatory: Update examples to use redesigned structures.
Update bdk::Wallet to use the redesigned structures.

Changelog notice

Initial implementation of the bdk_chain redesign (as mentioned in Redesigning bdk_chain around a "ChainOracle" #895). Currently, only the bdk_chain core structures are implemented. Persistence and updates to the current examples and bdk::Wallet will be done in separate PRs.

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

I've added tests for the new feature
I've added docs for the new feature

* Introduce `GraphedTx` struct to access transaction data of graphed transactions. * Ability to insert/access anchors and "seen at" values for graphed transactions. * `Additions` now records changes to anchors and last_seen_at.

The chain oracle keeps track of the best chain, while the transaction index indexes transaction data in relation to script pubkeys. This commit also includes initial work on `IndexedTxGraph`.

Add methods to `TxGraph` and `IndexedTxGraph` that gets in-best-chain data (such as transactions, txouts, unspent txouts).

Methods that list chain data have try and non-try versions. Both of these versions now return an `Iterator`. * Try versions return `Iterator<Item = Result>`. * Non-try versions require the `ChainOracle` implementation to be `ChainOracle<Error = Infallible>`.

* Get mutable index from `IndexedChainGraph`. * Also add `apply_additions` method to `TxIndex` trait.

…height This is important as a `ChainOracle` implementation is updated separately to an `IndexedTxGraph`.

evanlinjin · 2023-03-28T07:01:35Z

@rajarshimaitra will be working on adding unit tests for TxGraph and then IndexedTxGraph.

crates/chain/src/chain_data.rs

rajarshimaitra

Overall this looks good to me; two final nonblocking comments. The resolution for where to put the confirmation height should ideally be included in this PR. But if not can be done later. Tracking issue here #951

I am covering on the remaining tests for IndexedTxGraph. Need OwnedIndexer on SpkTxOutIndex for that. Will do it myself on my branch. If included in this PR anyway, would rebase on it.

crates/chain/src/spk_txout_index.rs

crates/chain/tests/test_indexed_tx_graph.rs

LLFourn

I'm approving this pending @evanlinjin addressing my comments in whatever way he wants. Thanks for all the work put into this @evanlinjin. It's sooooooo much better now. Looking forward to using this.

crates/chain/src/tx_graph.rs

crates/chain/src/chain_data.rs

crates/chain/src/tx_graph.rs

* `Additions` now implements `Append` and uses `Append` to implement `append()`. * `append()` logic enforces that `last_seen` values should only increase. * Test written for `append()` with `last_seen` behaviour.

* `IndexedTxGraph::try_balance` should include "confirmed and spendable" into `confirmed` balance. * `TxGraph::try_list_chain_unspents` filter logic should be reversed.

`SpkTxOutIndex` and `KeychainTxOutIndex` now both implement `OwnedIndexer`.

These tests cover list_txout, list_utxo and balance methods.

rajarshimaitra · 2023-04-28T11:39:19Z

ACK b799a57

I had some clean-up pushes for the tests. Should I push them here? (I don't have push access in your branch).

rajarshimaitra

ACK b799a57

I will push cleanups in a separate PR..

danielabrozzoni

Partial ACK b799a57 - good job! I haven't looked at the tests or at the methods implementations in depth, but I have reviewed the architecture and it looks good. I have a few non-blocking questions.

Let's goo 🚀

danielabrozzoni · 2023-04-28T16:10:55Z

crates/chain/src/tx_data_traits.rs

+/// Trait that "anchors" blockchain data to a specific block of height and hash.
+///
+/// I.e. If transaction A is anchored in block B, then if block B is in the best chain, we can
+/// assume that transaction A is also confirmed in the best chain. This does not necessarily mean
+/// that transaction A is confirmed in block B. It could also mean transaction A is confirmed in a
+/// parent block of B.


Looking at Anchor's definition, I'm wondering if there's something else it could make sense to implement it on, other than BlockId.
I'm not saying that Anchor shouldn't be a generic, I'm just wondering if you thought of any other structure that could be used as a anchor :)

Anchor implementations can be a lot more expressive. For example, Anchor with the exact confirmation height and/or time of the transaction. Or an Anchor with the exact merkle proof.

FWIW I think anchor should not be implemented on BlockId. The semantics of it are ambiguous. Does it imply that the transaction is anchored to that block because the transaction is in the block or does that block merely imply that the transaction is in the block? I didn't mention this because I thought the discussion would come up later anyway.

danielabrozzoni · 2023-04-28T16:26:37Z

crates/chain/src/indexed_tx_graph.rs

+}
+
+/// A trait that extends [`Indexer`] to also index "owned" script pubkeys.
+pub trait OwnedIndexer: Indexer {


(nit: this is not a super explicative name)

This is a side note, but I've actually started doubting whether we need this trait. It is basically used for filtering only (which can be done in layers above).

I'm not sure but I think I mentioned that this trait has the wrong name in my mind. It should at least have Spk in the name because it can only answer queries about owning spks. It can just be called SpkOwner. There's also no need to require it implements Indexer. I would define it as:

pub trait TxoOwner { pub fn owns(&self, tx: &Transaction, vout: u32) -> bool; }

because this is strictly more general and covers silent payments.

danielabrozzoni · 2023-04-28T16:29:17Z

crates/chain/src/local_chain.rs

+pub struct LocalChain {
+    blocks: BTreeMap<u32, BlockHash>,
+}


Is the LocalChain sparse, or does it have all the blocks?

evanlinjin force-pushed the chain_redesign_tx_graph_anchor branch from 7685ca2 to b9277fe Compare March 24, 2023 01:38

evanlinjin changed the title ~~Introduce TxAnchor trait~~ Introduce BlockAnchor trait Mar 24, 2023

evanlinjin mentioned this pull request Mar 24, 2023

Kill TransactionDetails #922

Closed

evanlinjin force-pushed the chain_redesign_tx_graph_anchor branch 2 times, most recently from 2f2278b to 9d4f0ca Compare March 24, 2023 03:58

[bdk_chain_redesign] Introduce BlockAnchor trait

5ae5fe3

* Introduce `GraphedTx` struct to access transaction data of graphed transactions. * Ability to insert/access anchors and "seen at" values for graphed transactions. * `Additions` now records changes to anchors and last_seen_at.

evanlinjin force-pushed the chain_redesign_tx_graph_anchor branch 4 times, most recently from aecc8f2 to 56bb46e Compare March 25, 2023 02:43

[bdk_chain_redesign] Introduce ChainOracle and TxIndex traits

61a8606

The chain oracle keeps track of the best chain, while the transaction index indexes transaction data in relation to script pubkeys. This commit also includes initial work on `IndexedTxGraph`.

evanlinjin force-pushed the chain_redesign_tx_graph_anchor branch 4 times, most recently from da62bbb to a038c00 Compare March 27, 2023 03:11

[bdk_chain_redesign] Add ..in_chain methods

43b648f

Add methods to `TxGraph` and `IndexedTxGraph` that gets in-best-chain data (such as transactions, txouts, unspent txouts).

evanlinjin force-pushed the chain_redesign_tx_graph_anchor branch from a038c00 to 43b648f Compare March 27, 2023 04:44

evanlinjin added 9 commits March 27, 2023 13:59

[bdk_chain_redesign] MOVE: IndexedTxGraph into submodule

6cbb18d

[bdk_chain_redesign] Add apply_additions to IndexedTxGraph

d0a2aa8

* Get mutable index from `IndexedChainGraph`. * Also add `apply_additions` method to `TxIndex` trait.

[bdk_chain_redesign] Add balance methods to IndexedTxGraph

db7883d

[bdk_chain_redesign] mut_index should be index_mut

313965d

[bdk_chain_redesign] Fix apply_additions logic for IndexedTxGraph.

e902c10

[bdk_chain_redesign] IndexedTxGraph keeps track of the last synced …

236c50f

…height This is important as a `ChainOracle` implementation is updated separately to an `IndexedTxGraph`.

[bdk_chain_redesign] Add docs

3440a05

[bdk_chain_redesign] Rm anchor type param for structs that don't use it

34d0277

evanlinjin changed the title ~~Introduce BlockAnchor trait~~ Introduce IndexedTxGraph Mar 28, 2023

evanlinjin requested review from LLFourn and danielabrozzoni March 28, 2023 07:10

evanlinjin mentioned this pull request Apr 24, 2023

Reevaluate "soundness" of is_mature method bitcoindevkit/bdk_wallet#155

Closed

evanlinjin requested review from LLFourn, rajarshimaitra and vladimirfomene April 25, 2023 03:02

rajarshimaitra reviewed Apr 25, 2023

View reviewed changes

crates/chain/src/chain_data.rs Show resolved Hide resolved

rajarshimaitra reviewed Apr 25, 2023

View reviewed changes

crates/chain/src/spk_txout_index.rs Show resolved Hide resolved

crates/chain/tests/test_indexed_tx_graph.rs Show resolved Hide resolved

This was referenced Apr 25, 2023

Put locktime into FullTxOut #950

Closed

Resolve where to put Confirmation Height #951

Closed

[bdk_chain_redesign] Fix tx_graph::Additions::append logic

f101dde

evanlinjin mentioned this pull request Apr 26, 2023

[Feature request] Add timestamp when transaction has been boardcasted/seen first. #587

Closed

LLFourn mentioned this pull request Apr 27, 2023

Rename the tx field of additions as txs #954

Closed

LLFourn approved these changes Apr 27, 2023

View reviewed changes

evanlinjin and others added 4 commits April 28, 2023 18:54

[bdk_chain_redesign] Fix tx_graph::Additions::append logic

e536307

* `Additions` now implements `Append` and uses `Append` to implement `append()`. * `append()` logic enforces that `last_seen` values should only increase. * Test written for `append()` with `last_seen` behaviour.

[bdk_chain_redesign] Fix calculation bugs.

911af34

* `IndexedTxGraph::try_balance` should include "confirmed and spendable" into `confirmed` balance. * `TxGraph::try_list_chain_unspents` filter logic should be reversed.

[bdk_chain_redesign] Implement OwnedIndexer for indexers

8cd0328

`SpkTxOutIndex` and `KeychainTxOutIndex` now both implement `OwnedIndexer`.

[bdk_chain_redesign] Add tests for IndexedTxGraph with LocalChain

b799a57

These tests cover list_txout, list_utxo and balance methods.

evanlinjin mentioned this pull request Apr 28, 2023

More IndexedTxGraph tests #956

Closed

3 tasks

evanlinjin requested a review from rajarshimaitra April 28, 2023 11:32

rajarshimaitra approved these changes Apr 28, 2023

View reviewed changes

evanlinjin changed the title ~~Introduce IndexedTxGraph~~ Introduce redesigned bdk_chain structures Apr 28, 2023

evanlinjin added the Optech Make Me Famous! 🤩 For anything of interest to Optech newsletter label Apr 28, 2023

danielabrozzoni approved these changes Apr 28, 2023

View reviewed changes

danielabrozzoni merged commit 139e3d3 into bitcoindevkit:master Apr 28, 2023

evanlinjin mentioned this pull request Apr 28, 2023

More tests for IndexedTxGraph and TxGraph #958

Closed

3 tasks

rajarshimaitra mentioned this pull request Apr 29, 2023

Cleanup IndexedTxGraph test. #959

Merged

3 tasks

LLFourn mentioned this pull request May 1, 2023

Issue 954 evanlinjin/bdk#3

Closed

evanlinjin mentioned this pull request May 3, 2023

Various tweaks to redesigned structures #963

Merged

5 tasks

notmandatory removed the BDK 1.0.0 label May 6, 2023

notmandatory mentioned this pull request Jul 4, 2023

Release 1.0.0-alpha.1 #1025

Closed

24 tasks

Conversation

evanlinjin commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

evanlinjin commented Mar 28, 2023

Uh oh!

Uh oh!

rajarshimaitra left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LLFourn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajarshimaitra commented Apr 28, 2023

Uh oh!

rajarshimaitra left a comment

Choose a reason for hiding this comment

Uh oh!

danielabrozzoni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

evanlinjin commented Mar 24, 2023 •

edited

Loading

rajarshimaitra left a comment •

edited

Loading