Clean up android instrumented tests#845
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Sep 3, 2025
Merged
Conversation
ItoroD
approved these changes
Sep 3, 2025
Collaborator
|
ACK c0a6d00 |
reez
approved these changes
Sep 3, 2025
Member
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings similar tests to what we have on bdk-jvm.
It's just the beginning, but it's a clean up of what we had before. It removes all "live" tests that used Signet. This ensures that what we have here can run in the CI on every PR without being fickle.
I plan on adding a ton more! But for now this is a simple refactor of the tests we have.
This should go in before #821 and #825, as I'll add tests for those once this is in.