Add coin selection to tx_builder#821
Closed
thunderbiscuit wants to merge 2 commits intobitcoindevkit:masterfrom
Closed
Add coin selection to tx_builder#821thunderbiscuit wants to merge 2 commits intobitcoindevkit:masterfrom
thunderbiscuit wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
037d928 to
13b70fa
Compare
11163bd to
f4fcbf8
Compare
Member
Author
|
This way to handling coin selection is going away since the TxBuilder is being refactored for 3.0 and leveraging the bdk-tx crate instead. See bitcoindevkit/bdk_wallet#297 for development on this. I think we're too close to 3.0 to make it worth our while to break everything, force users to update their code with the TxBuilder, just to then change it again in 3.0. This is not a requested/important feature enough to warrant the work IMO. We can instead focus on exposing the new transaction building methods once they come out. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is particularly ugly. This is because the TxBuilder is generic in its coin selection algo, but we were only using 1 version of this generic and TxBuilder so far, so everything was easy.
I do think this could be cleaned up. I just wanted to run the tests and show where I'm at.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: