[Merged by Bors] - Add bevy_ecs::schedule_v3 module
#6587
Conversation
maniwani
added
A-ECS
james7132
left a comment
james7132
left a comment
There was a problem hiding this comment.
This is just a cursory scan. A full review to come later.
| fn init(&mut self, schedule: &SystemSchedule) { | ||
| let sys_count = schedule.system_ids.len(); | ||
| let set_count = schedule.set_ids.len(); | ||
| self.completed_sets = FixedBitSet::with_capacity(set_count); |
There was a problem hiding this comment.
nit: The sys_count/set_count is not used elsewhere, directly passing them in here is probably as readable as it is now.
maniwani
force-pushed
the
stageless
branch
4 times, most recently
from
42c96cc to
7754cda
Compare
maniwani
force-pushed
the
stageless
branch
2 times, most recently
from
e0bd75b to
1d5f5a4
Compare
| derive_label(input, &trait_path, "run_criteria_label") | ||
| } | ||
|
|
||
| /// Derive macro generating an impl of the trait `ScheduleLabel`. |
There was a problem hiding this comment.
Are we able to doc link these traits?
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
My previous comments are all resolved and I think this is in a good spot now! One more small optimization that I think we can do now (see below), but I think we're good to go!
|
bors r+ |
|
This PR consistently timeout CI: https://github.com/bevyengine/bevy/actions/workflows/ci.yml?query=branch%3Astageless, while other PR are running without issues. This would point to an issue in this one... |
|
Running tests using the |
|
Timed out. |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
bevy_ecs::schedule_v3 modulebevy_ecs::schedule_v3 module
13 participants
Objective
Complete the first part of the migration detailed in bevyengine/rfcs#45.
Solution
Add all the new stuff.
TODO
Write more tests.(will do later)Replace(will do later)petgraph.