[Merged by Bors] - Re-implement Automatic Sprite Sizing #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Aug 10, 2021
| } | ||
|
|
||
| /// System that resizes sprites that have their resize mode set to automatic | ||
| pub fn sprite_auto_resize_system( |
Member
There was a problem hiding this comment.
I think this is fine for now (and i know this is the approach we currently use), but its worth calling out that we can probably do better than polling every texture for every sprite every frame. But I'm fine eating the perf cost (~0.9 milliseconds per frame for 67,000 sprites in bevymark_pipelined or ~3 fps).
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
# Objective - Prevent the need to specify a sprite size when using the pipelined sprite renderer ## Solution - Re-introduce the sprite auto resize system from the old renderer
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution